-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollouts doesn't drop old replicaset/pods #3836
Labels
bug
Something isn't working
Comments
I think this is fixed in 1.7.2 or atleast improved can you try. |
This is log for v1.7.1+6a99ea9 (soon we are going to update to the latest version as advised) Most interesting thing is
As result it sets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist:
Describe the bug
Sometimes Argo Rollouts switches release to new version (replicaset) but don't remove old one, so pods are always running.
After some digging into it I've realized that the reason of that is blank value of annotation
argo-rollouts.argoproj.io/scale-down-deadline: ""
but correct date should be there. That's why controller can't remove it later.To Reproduce
I have no reproduce steps for this problem because it accidentally occurs after rollout process. Here is the process of my digging
#1761 (comment)
#1761 (comment)
Expected behavior
Controller shoud remove pods in non-active replica.
Screenshots
svc-c6dcc48cb
is still alive when newer replicasetsvc-865f9fcf88
was buried and even newer onesvc-74ff5588fb
is currently working.Version
app version: v1.7.1+6a99ea9
helm version: "2.37.1"
Logs
Have no logs for now.
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
The text was updated successfully, but these errors were encountered: