Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for real tracing #372

Open
yeya24 opened this issue Feb 3, 2022 · 0 comments
Open

feat: Add support for real tracing #372

yeya24 opened this issue Feb 3, 2022 · 0 comments

Comments

@yeya24
Copy link
Contributor

yeya24 commented Feb 3, 2022

Now a Tracer interface is added to support adding some fields to the logger https://github.com/argoproj/gitops-engine/blob/master/pkg/utils/tracing/api.go#L10.
We want to add real opentracing/opentelemetry support based on this interface. However, to support real tracing, an additional argument ctx needs to be passed to the StartSpan interface so that the span context can be propagated.

Additionaly, it would be great to refactor this interface. It is hard to add opentracing span options using the current interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant