-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQUEST] Add Cmake support #28
Comments
@WSLUser
First off, which platform are you referring to that doesn't support |
Windows for one, but I think there are others based on arch or other reasons. I'm not sure how Visual Studio handles cmake, maybe they use the Msys2 or WSL make in the backend. Right now point is, I want to see the project available for as many platform and architectures as possible and that requires doing things like adding cmake support. |
Windows is very unlikely to be supported unless someone else takes on that pretty big challenge. Btop++ is written with very much POSIX in mind, things like threading, signal handling and input are very much POSIX dependent. Changing the build system for something that isn't even looked at being implemented and if it was, likely would take a long time to finish would be extremely premature. |
There was a lot of discussion in #82 but the TL:DR is that there will be no cmake in this repo unless it becomes necessary. I also setup a notification whenever the Makefile changes and I'll do my best to keep the cmake file in sync. @aristocratos following the discussion in #82 I feel it makes little sense to keep this issue open, since it's idea is basically declined for now. |
Closing for now. @jan-guenter |
@aristocratos That's up to you, but might be interesting for some. |
@aristocratos Different idea: Perhaps a wiki page would be more useful than bloating the readme with information not strictly relating to this project. You could still link the wiki page in the readme. |
That is a good idea, but then there also the expectation that I should fill it with useful information :) Will take a look at it when I've got time. |
@aristocratos |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
There are many benefits from using Cmake. Check out the documentation. Biggest one is portability. On platforms where
Make
isn't available, Cmake can still be made use of.Describe the solution you'd like
A clear and concise description of what you want to happen.
I'd like to see this project built with llvm, which requires Cmake support. Compiler optimizations are much better using llvm.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Do nothing.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: