Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] improve .tar packaging #358

Closed
nivex opened this issue Jun 6, 2022 · 5 comments
Closed

[REQUEST] improve .tar packaging #358

nivex opened this issue Jun 6, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@nivex
Copy link

nivex commented Jun 6, 2022

  1. The current .tar files are tarbombs. It would be best to have all the files in a directory inside the tarball.
  2. It would be nice if the filenames (and the future directory mentioned above) contained the version of the release, eg: btop-1.2.7 instead of just btop.
@nivex nivex added the enhancement New feature or request label Jun 6, 2022
@userdocs
Copy link

userdocs commented Jun 7, 2022

1: no real opinion on.

2: How would this benefit or help the project or end users when using the GitHub release management system?

I don't think it's needed when the api can provide all release specific versioning info needed if that info is required,

Whereas using a system like this https://ftp.gnu.org/gnu/libtool/ it would make sense.

@nivex
Copy link
Author

nivex commented Jun 8, 2022

  1. Over the years I've gotten in the habit of running tar tf foo.tar to check for tarbombs, but not everyone does. Also, sometimes I forget. In the case of this project I would end up with a directory full of random files. This is not a fun experience, especially if one does this in their home directory.

  2. As an end user, I go to this project's release page and grab a tarball. I don't know anything or care about GitHub's release management system. It would be a convenience to be able to see at a glance of the filename on my local filesystem what version(s) I have downloaded (especially if they've been sitting there awhile) rather than have to unpack it and poke around.

@Gerrit-K
Copy link

Gerrit-K commented Nov 7, 2022

Not sure how or why this changed, but the most recent release (1.2.13, at the time of writing) now contains a folder within the tarballs.

I noticed this because it broke my package manager and I was looking for an open or closed issue related to this to understand the reason for the change, but the only thing I found was this issue here, which leads me to believe it was not really intentional? 🤔 I didn't have the time to dig deeper but if someone finds something, I'd be interested in the details. Other than that, I hope it remains stable now.

@aristocratos
Copy link
Owner

@Gerrit-K
See #242

Which package manager are you using that uses the release binaries from github?

@Gerrit-K
Copy link

Gerrit-K commented Nov 7, 2022

@aristocratos sorry, "package manager" was probably not the right term here. It's merely a zsh plugin manager (zinit), which can also be used to download arbitrary artifacts from github release pages. It automatically extracts tarball archives, but in most cases I need to point it to the correct binary path. This path has changed in the recent release, which is how I caught it. But the fix on my end was pretty simple. Thanks for providing the context 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants