Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No newline written to the end of btop.conf #366

Open
rpdelaney opened this issue Jun 15, 2022 · 0 comments
Open

[BUG] No newline written to the end of btop.conf #366

rpdelaney opened this issue Jun 15, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rpdelaney
Copy link

Describe the bug

There is no newline at the end of btop.conf. This can cause conflicts, for instance when dotfiles are under source control and git expects them.

To Reproduce

Run btop, change any configuration option, and quit:

$ git diff .
diff --git i/home/.config/btop/btop.conf w/home/.config/btop/btop.conf
index def875a..b3db07b 100644
--- i/home/.config/btop/btop.conf
+++ w/home/.config/btop/btop.conf
@@ -25,7 +25,7 @@ presets = "cpu:1:default,proc:0:default cpu:0:default,mem:0:default,net:0:defaul
 vim_keys = True

 #* Rounded corners on boxes, is ignored if TTY mode is ON.
-rounded_corners = True
+rounded_corners = False

 #* Default symbols to use for graph creation, "braille", "block" or "tty".
 #* "braille" offers the highest resolution but might not be included in all fonts.
@@ -200,4 +200,4 @@ selected_battery = "Auto"

 #* Set loglevel for "~/.config/btop/btop.log" levels are: "ERROR" "WARNING" "INFO" "DEBUG".
 #* The level set includes all lower levels, i.e. "DEBUG" will show all logging info.
-log_level = "WARNING"
+log_level = "WARNING"
\ No newline at end of file

Expected behavior

The configuration should be changed without removing the trailing newline:

diff --git i/home/.config/btop/btop.conf w/home/.config/btop/btop.conf
index def875a..8fde49c 100644
--- i/home/.config/btop/btop.conf
+++ w/home/.config/btop/btop.conf
@@ -25,7 +25,7 @@ presets = "cpu:1:default,proc:0:default cpu:0:default,mem:0:default,net:0:defaul
 vim_keys = True

 #* Rounded corners on boxes, is ignored if TTY mode is ON.
-rounded_corners = True
+rounded_corners = False

 #* Default symbols to use for graph creation, "braille", "block" or "tty".
 #* "braille" offers the highest resolution but might not be included in all fonts.

Info (please complete the following information):

  • btop++ version: btop -v

btop version: 1.2.7

  • Binary:

homebrew

  • (If compiled) Compiler and version:

N/A

  • Architecture: [x86_64, aarch64, etc.] uname -m

arm64

  • Platform: [Linux, FreeBSD, OsX]

macOS-12.4-arm64-arm-64bit

  • (Linux) Kernel: uname -r
  • (OSX/FreeBSD) Os release version:
  • Terminal used:

kitty

  • Font used:

Iosevka

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants