[Storybooks] Static build is broken

[alloy]

Probably this issue.

[orta]

When Storybooks 3.2.0 comes out, I'll look into this and updating storybooks

[kanaabe]

After 3.2.0 it looks like regular builds are now failing too. Issue seems to be in the node ./node_modules/.bin/build-storybook step of yarn deploy-storybook.

If I turn silent mode off here, I see the bug is from chunkhash:

(node:31241) DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead.
Failed to build the storybook
chunk manager [entry]
static/[name].[chunkhash].bundle.js
Cannot use [chunkhash] for chunk in 'static/[name].[chunkhash].bundle.js' (use [hash] instead)
Error: Cannot use [chunkhash] for chunk in 'static/[name].[chunkhash].bundle.js' (use [hash] instead)
    at MainTemplate.replacePathVariables (/Users/kanaabe/Development/Artsy/reaction/node_modules/@storybook/react/node_modules/webpack/lib/TemplatedPathPlugin.js:64:9)

Next step for me is to figure out how to fix this, but i'm posting here in case this is obvious to anyone!

[kanaabe]

The problem seems to be with using the HotModuleReplacementPlugin in our storybook webpack config. Removing this will build the storybook and make it deployable. @orta I know you were working on HMR a bit...do you know why we use this plugin? I thought storybook comes with HMR. Removing the plugin doesn't make HMR work, but maybe it's a different issue?

[orta]

@kanaabe - make the config not do HMR when deploying 👍

That's legit

[alloy]

Nice sleuthing @kanaabe 🙌