Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubmitInfoBuilder: have two slices, but only one count. #239

Closed
cheako opened this issue Oct 2, 2019 · 2 comments
Closed

SubmitInfoBuilder: have two slices, but only one count. #239

cheako opened this issue Oct 2, 2019 · 2 comments

Comments

@cheako
Copy link

cheako commented Oct 2, 2019

wait_semaphore_count is shared by p_wait_semaphores and p_wait_dst_stage_mask, but there are two functions used to set these and they can be passed different counts. This silently leads to crashes that validation layers don't catch.

@aloucks
Copy link
Contributor

aloucks commented Oct 26, 2019

I believe the documentation is stating that it's your responsibility to assert those arrays are of the same length.

https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkSubmitInfo.html

Valid Usage (Implicit)

If waitSemaphoreCount is not 0, pWaitSemaphores must be a valid pointer to an array of waitSemaphoreCount valid VkSemaphore handles

If waitSemaphoreCount is not 0, pWaitDstStageMask must be a valid pointer to an array of waitSemaphoreCount valid combinations of VkPipelineStageFlagBits values

EDIT: See also: #210

@MarijnS95
Copy link
Collaborator

We had a newer report about this in #445, with some more context, so I'll close this as duplicate. It's still something I'd like to clean up in the next breaking release though.

@MarijnS95 MarijnS95 closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants