Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awkward generated name in PhysicalDeviceLimits::max_image_dimension1_d #391

Open
Rua opened this issue Mar 8, 2021 · 3 comments
Open

Awkward generated name in PhysicalDeviceLimits::max_image_dimension1_d #391

Rua opened this issue Mar 8, 2021 · 3 comments
Labels

Comments

@Rua
Copy link
Contributor

Rua commented Mar 8, 2021

I'm assuming that this is a mishap with some kind of auto-generating script, and that it should really be max_image_dimension_1d or max_image_dimension_1D. The same happens with 2_d and 3_d, and probably other occurrences of this elsewhere. It would be easy to fix with a PR, but I want to report it in case the thing that produced these names needs fixing.

@MaikKlein
Copy link
Member

Thanks, I wasn't aware of this. Seems like we generated max_image_dimension1d in the past, but it should be max_image_dimension_1d.

@MaikKlein MaikKlein added the bug label Mar 8, 2021
@MarijnS95
Copy link
Collaborator

That looks to be intended by snek, inserting an _ between a number followed by an uppercase letter. Responsible bit is here if you want to patch it:

https://github.com/MaikKlein/ash/blob/b3a010a3154d0cd9d4943e794a0e90916da93936/generator/src/lib.rs#L725-L732

@aloucks
Copy link
Contributor

aloucks commented Mar 15, 2021

At one point I was building a generator and had some functions for name conversion that handled a bunch of weird edge cases in vulkan names. It's posted in this gist if you're interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants