Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use [repr(transparent)] instead of [repr(C)] #72

Closed
TimDiekmann opened this issue Jul 8, 2018 · 6 comments
Closed

Use [repr(transparent)] instead of [repr(C)] #72

TimDiekmann opened this issue Jul 8, 2018 · 6 comments

Comments

@TimDiekmann
Copy link

Since [repr(transparent)] is now stabilized you may consider to use it instead of [repr(C)] for the handles (here and here).

I'd do a PR if you want. This could also be enabled with a feature.
@MaikKlein
Copy link
Member

We will switch to it when it is on stable.

@zakarumych
Copy link

zakarumych commented Jul 9, 2018 •
edited
Loading

It should be stable in 1.28 though.
This is must-have as current approach doesn't guaranteed to work.

@TimDiekmann
Copy link
Author

It's stabilized on 1.28 but the stable branch is 1.26 currently.

@zakarumych
Copy link

zakarumych commented Jul 9, 2018 •
edited
Loading

I believe it is 1.27 (at least that's what rustc --version say)

@TimDiekmann
Copy link
Author

Oh, right. However, not 1.28 though :)

@zakarumych
Copy link

It's time.

@TimDiekmann TimDiekmann mentioned this issue Aug 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MaikKlein @zakarumych @TimDiekmann