Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden API for registerFunction in LessphpFilter #26

Open
robjmills opened this issue Jan 17, 2022 · 2 comments
Open

Hidden API for registerFunction in LessphpFilter #26

robjmills opened this issue Jan 17, 2022 · 2 comments

Comments

@robjmills
Copy link

The LessphpFilter does not provide an interface to the registerFunction method in lessc.inc.php, however the ScssphpFilter does provide an interface to this through \Assetic\Filter\ScssphpFilter::registerFunction. Is there a reason there isn't parity between these 2 filters? I'm happy to do a PR to add this in, if it's likely to be approved.

thanks!
@LukeTowers
Copy link
Member

No explicit reasoning for it nope; if your PR exposes existing functionality and works fine then I'm happy to review and merge it. Please ensure a test case is added for the change though :) Thanks!

@LukeTowers
Copy link
Member

@robjmills are you still interested in adding this functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robjmills @LukeTowers