Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action to add file-level ignore on violation #253

Open
zanieb opened this issue Sep 27, 2023 · 4 comments
Open

Action to add file-level ignore on violation #253

zanieb opened this issue Sep 27, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@zanieb
Copy link
Member

zanieb commented Sep 27, 2023

A quick fix for a violation shows an option to "Ignore the violation on this line", I'd like the additional option to "Ignore the violation in this file" which would be useful since I don't necessarily remember the syntax to do so :)

@zanieb zanieb added the enhancement New feature or request label Sep 27, 2023
@charliermarsh
Copy link
Member

My only concern would be that we're starting to accumulate a lot of quick fix actions 😂

@MichaReiser
Copy link
Member

My only concern would be that we're starting to accumulate a lot of quick fix actions 😂

That, and I don't think suppressing an entire violation for an entire file is something we want to encourage. How do other linter solve this? Could we add a command instead?

@zanieb
Copy link
Member Author

zanieb commented Oct 2, 2023

I think it makes a lot more sense as a code-action than a command. A command feels like we're encouraging it more i.e. you can apply it to multiple files at once. A code-action is like.. do this manually once.

I don't think suppressing an entire violation for an entire file is something we want to encourage

I guess the other option is to suggest using per-file-ignores instead? I'm not sure that's really better though.

@dhruvmanila
Copy link
Member

FWIW, Lua language server provides 3 options (line, file, workspace):

Screenshot 2023-10-04 at 12 40 08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants