Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Clean up atom.coffee #1431

Closed
kevinsawicki opened this issue Jan 16, 2014 · 6 comments
Closed

Clean up atom.coffee #1431

kevinsawicki opened this issue Jan 16, 2014 · 6 comments

Comments

@kevinsawicki
Copy link
Contributor

I don't think we need the duplicate methods such as getVersion and @getVersion now that telepath isn't being used.

@probablycorey
Copy link

Do you want to get rid of getVersion or @getVersion

@kevinsawicki
Copy link
Contributor Author

I was thinking @getVersion unless there is a reason we can't.

@probablycorey
Copy link

It is used in some class methods, but maybe they won't be needed after the atom.coffee cleanup

@nathansobo
Copy link
Contributor

I really like being able to call Atom.loadOrCreate as a mechanism for creating the Atom instance with its state up-front. I'm pretty sure Atom.getVersion has nothing to do with that, so I'm cool killing it. But I hope some of the class methods supporting .loadOrCreate can stick around.

@probablycorey
Copy link

Closed by 88d1ba2

@lock
Copy link

lock bot commented Jan 26, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants