Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primitive Mode TRIANGLE_STRIP and TRIANGLE_FAN #316

Open
atteneder opened this issue Feb 7, 2022 · 2 comments
Open

Primitive Mode TRIANGLE_STRIP and TRIANGLE_FAN #316

atteneder opened this issue Feb 7, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@atteneder
Copy link
Owner

The following glTF primitive modes are not implemented:

-TRIANGLE_STRIP
-TRIANGLE_FAN

Unity does not support those out of the box, so glTFast needs to generate indices (similar to how it creates them for missing indices on TRIANGLES mode primitives).

Unfortunately I've never encountered such a glTF file, so we'd have to find or create one first.

@atteneder atteneder added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 7, 2022
@Hexer611
Copy link
Contributor

Chronos group has a glTF asset generator which should be useful as an example to implement these primitive modes.
Link: https://github.khronos.org/glTF-Asset-Generator/Output/Positive/Mesh_PrimitiveMode/

I would like to contribute to this project. Since this issue is tagged with "good first issue" I believe this is a good point to try it :D

Out of context note: The link to "code of conduct" in "https://github.com/atteneder/glTFast/blob/openupm/CONTRIBUTING.md" doesn't work, I could send a PR to fix that if possible :D

@atteneder
Copy link
Owner Author

@Hexer611 Thanks for going ahead and submitting PRs.

Regarding the incorrect linke: Sure, go ahead! Targetting the Unity fork is the way to go.

I'll look at your PR in 1-2 weeks.

Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Runtime Loading
Development

No branches or pull requests

2 participants