Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-msk-alpha): (add vpc connectivity interface to msk-alpha construct) #26690

Closed
1 of 2 tasks
fridgerator opened this issue Aug 9, 2023 · 5 comments
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@fridgerator
Copy link

fridgerator commented Aug 9, 2023

Describe the feature

VPC Connectivity exists as a part of the L1 CfnCluster construct, however these props are not exposed to aws-msk-alpha Cluster. This feature would add an interface for the Vpc Connectivity props, to be passed down to the underlying CfnCluster.

Use Case

The current solution is to create a new MSK Cluster then use a custom resource to make api calls that enable VPC Connectivity , which can take a long time. It would be beneficial if a cluster could be created with this already enabled via the aws-msk-alpha construct.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.90.0

Environment details (OS name and version, etc.)

Mac OS Ventura, Typescript

@fridgerator fridgerator added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 9, 2023
@github-actions github-actions bot added the @aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) label Aug 9, 2023
@peterwoodworth peterwoodworth added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 9, 2023
@peterwoodworth
Copy link
Contributor

Thanks for the report, makes sense 👍🏻

Note that you can use escape hatches to make use of these L1 properties without our explicit support

@fridgerator
Copy link
Author

Actually this may not be supported.

I tried:

const cluster = new msk.Cluster...
const cfnCluster = cluster.node.defaultChild as CfnCluster;
cfnCluster.addOverride("Properties.BrokerNodeGroupInfo.ConnectivityInfo.VpcConnectivity.ClientAuthentication.Sasl.Iam.Enabled", true)
cfnCluster.addOverride("Properties.BrokerNodeGroupInfo.ConnectivityInfo.VpcConnectivity.ClientAuthentication.Tls.Enabled", true)

And when I deployed I got a 400 error:

When creating a cluster, all vpcConnectivity auth schemes must be disabled ('enabled' : false). You can enable auth schemes after the cluster is created. (Service: Kafka, Status Code: 400, Request ID: xxxx) 'vpcConnectivity.clientAuthentication'" (RequestToken: xxxx, HandlerErrorCode: InvalidRequest)

@peterwoodworth
Copy link
Contributor

Hmm you may want to reach out to the CloudFormation coverage roadmap in that case

@peterwoodworth peterwoodworth added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. labels Aug 9, 2023
@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Aug 12, 2023
@github-actions github-actions bot added closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Aug 17, 2023
@khaleqi
Copy link

khaleqi commented Feb 12, 2024

It would be great if anyone could share working solution for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants