Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::Cognito::UserPool: not supported for hotswap deployments #30838

Closed
wcheek opened this issue Jul 12, 2024 · 3 comments
Closed

AWS::Cognito::UserPool: not supported for hotswap deployments #30838

wcheek opened this issue Jul 12, 2024 · 3 comments
Labels
bug This issue is a bug. cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort p2 package/tools Related to AWS CDK Tools or CLI response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@wcheek
Copy link

wcheek commented Jul 12, 2024

Describe the bug

Every time I run cdk deploy with --hotswap or --hotswap-fallback I am notified that I have non-Asset changes and it must fall back to a full deployment

Expected Behavior

hotswap succeeds without needing to fall back to a full deployment.

It seems like these /should/ be hotswappable changes, since they are just settings of my UserPool. By not being hotswappable, this issue slows down my deployments.

Current Behavior

⚠️ The following non-hotswappable changes were found:
    logicalID: XXXXXXXXX, type: AWS::Cognito::UserPool, 
rejected changes: AdminCreateUserConfig,EmailVerificationMessage,EmailVerificationSubject,VerificationMessageTemplate, 
reason: This resource type is not supported for hotswap deployments

Could not perform a hotswap deployment, as the stack XXXX contains non-Asset changes
Falling back to doing a full deployment

Reproduction Steps

  1. Define a UserPool with these settings:
    let userPool = new cognito.UserPool(this, "userPool", {
...
      userVerification: {
        emailSubject: "....",
        emailBody: `.... `,
      },
      userInvitation: {
        emailSubject: "....",
        emailBody: `....`,
      },
    });
  1. Run cdk deploy --hotswap or cdk deploy --hotswap-fallback

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.148.0 (build e5740c0)

Framework Version

No response

Node.js Version

v20.11.1

OS

Ubuntu 22.04.4 LTS

Language

TypeScript

Language Version

5.4.3

Other information

No response

@wcheek wcheek added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Jul 12, 2024
@ashishdhingra
Copy link
Contributor

@wcheek Good morning. Your issue appears to be similar to existing issue #28058. Please review if this is the case and close this one.

Thanks,
Ashish

@ashishdhingra ashishdhingra removed the needs-triage This issue or PR still needs to be triaged. label Jul 12, 2024
@ashishdhingra ashishdhingra self-assigned this Jul 12, 2024
@ashishdhingra ashishdhingra added p2 effort/medium Medium work item – several days of effort labels Jul 12, 2024
@ashishdhingra ashishdhingra removed their assignment Jul 12, 2024
@ashishdhingra ashishdhingra added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. package/tools Related to AWS CDK Tools or CLI cli Issues related to the CDK CLI and removed @aws-cdk/aws-cognito Related to Amazon Cognito labels Jul 12, 2024
@wcheek wcheek closed this as completed Jul 12, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort p2 package/tools Related to AWS CDK Tools or CLI response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants