Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing/invalid dependency declaration on @aws-sdk/signature-v4-crt #3375

Closed
oliversalzburg opened this issue Feb 28, 2022 · 3 comments
Closed
Labels
bug This issue is a bug. response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days.

Comments

@oliversalzburg
Copy link

oliversalzburg commented Feb 28, 2022

Describe the bug

Using certain parts of the SDK does not work, because the dependency declarations are invalid.

Your environment

SDK version number

@aws-sdk/client-s3@npm:3.53.1
@aws-sdk/s3-request-presigner@npm:3.53.1

Is the issue in the browser/Node.js/ReactNative?

Node.js

Details of the browser/Node.js/ReactNative version

v16.14.0

Steps to reproduce

yarn install @aws-sdk/client-s3

Observed behavior

Received warnings about invalid/missing dependency declarations:

➤ YN0002: │ @aws-sdk/client-s3@npm:3.53.1 doesn't provide @aws-sdk/signature-v4-crt (p3de4d), requested by @aws-sdk/middleware-sdk-s3
➤ YN0002: │ @aws-sdk/s3-request-presigner@npm:3.53.1 doesn't provide @aws-sdk/signature-v4-crt (pb9ba7), requested by @aws-sdk/middleware-sdk-s3

Expected behavior

Missing dependency declarations of this kind are not allowed in our code base, which requires us to fix the SDK itself through manual patches. The SDK should have proper dependency declarations that allow installation without warnings/errors and should not require consumers to patch the SDK themselves.

Additional context

For other consumers who struggle with the same issue, it can be worked around with the following package extensions:

packageExtensions:
  "@aws-sdk/client-s3@*":
    dependencies:
      "@aws-sdk/signature-v4-crt": "*"
  "@aws-sdk/s3-request-presigner@*":
    dependencies:
      "@aws-sdk/signature-v4-crt": "*"
@oliversalzburg oliversalzburg added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 28, 2022
@RanVaknin
Copy link
Contributor

Hi @oliversalzburg,

The aws-crt package is large, so we intentionally exclude it from the @aws-sdk/client-s3 package.

You can read more about it here, but I saw you commented on this issue in the past so you might be aware of it already.

Please consider contributing to our documentation with your workaround.

Thank you!

@RanVaknin RanVaknin added response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 9, 2022
@oliversalzburg
Copy link
Author

This is not a documentation issue. This was an issue with your dependency declarations. You have fixed it in the meanwhile. Probably in 16aa220. Thanks for the attentive support.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants