Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate File awsSdkSigV4AConfigSelector.d.ts breaking deployments #6464

Closed
3 tasks done
noynek opened this issue Sep 11, 2024 · 7 comments · Fixed by #6467
Closed
3 tasks done

Duplicate File awsSdkSigV4AConfigSelector.d.ts breaking deployments #6464

noynek opened this issue Sep 11, 2024 · 7 comments · Fixed by #6467
Assignees
Labels
bug This issue is a bug. p1 This is a high priority issue queued This issues is on the AWS team's backlog

Comments

@noynek
Copy link

noynek commented Sep 11, 2024

Checkboxes for prior research

Describe the bug

Our builds recently started failing when updating from 3.645.0 to 3.649.0, and we were able to trace it to duplicate awsSdkSigV4AConfigSelector.d.ts files. When I try to unzip our build zip file, I get this error. I'm guessing there's a case sensitivity issue.

SDK version number

@aws-sdk/package-name@version, ...

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v20.12.1

Reproduction Steps

We're using azure with github actions so it's a little hard to provide repro instructions. Hoping the bug description is enough.

Observed Behavior

Our logs showed

Run From Package Initialization failed. Zip Contains 2 duplicate files with identical name in the same path
It was only when trying to unzip that we could see that the issue came from the aws package.

Expected Behavior

zip-based builds to succeed. No duplicate files.

Possible Solution

No response

Additional Information/Context

No response

@noynek noynek added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 11, 2024
@timtucker-dte
Copy link

timtucker-dte commented Sep 12, 2024

We also started seeing this yesterday.

The two files we see:

node_modules/@aws-sdk/core/dist-es/submodules/httpAuthSchemes/aws_sdk/awsSdkSigV4AConfigSelector.js
node_modules/@aws-sdk/core/dist-es/submodules/httpAuthSchemes/aws_sdk/AwsSdkSigV4AConfigSelector.js

Content in the 2 files is exactly the same as well.

@kuhe kuhe added queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Sep 12, 2024
@kuhe kuhe self-assigned this Sep 12, 2024
@kuhe kuhe added p2 This is a standard priority issue p1 This is a high priority issue and removed p2 This is a standard priority issue labels Sep 12, 2024
@trivikr trivikr assigned trivikr and unassigned kuhe Sep 12, 2024
@trivikr

This comment was marked as outdated.

@trivikr
Copy link
Member

trivikr commented Sep 12, 2024

I'm able to see duplicate files in @aws-sdk/core@3.649.0 in operating system with case sensitive file system, like Linux.

$ mkdir test-install && cd test-install

$ test-install> npm install @aws-sdk/core@3.649.0 --save-exact

$ test-install> ls -1a node_modules/@aws-sdk/core/dist-es/submodules/httpAuthSchemes/aws_sdk
.
..
awsSdkSigV4AConfigSelector.js
AwsSdkSigV4AConfigSelector.js
AwsSdkSigV4ASigner.js
AwsSdkSigV4Signer.js
index.js
resolveAwsSdkSigV4AConfig.js
resolveAwsSdkSigV4Config.js

Also verified in npmjs file browser https://www.npmjs.com/package/@aws-sdk/core?activeTab=code

@trivikr
Copy link
Member

trivikr commented Sep 12, 2024

This happened as TurboRepo cached artifact from an intermediate state of the @aws-sdk/core from a developer workspace, and it reused that cache from release since the source artifacts hadn't changed.

One long-term fix would be clean like rimraf dist-es && build:es to all our package.json build scripts.

@noynek
Copy link
Author

noynek commented Sep 13, 2024

Thank you very much.

@trivikr
Copy link
Member

trivikr commented Sep 13, 2024

The fix is merged in #6467, and new version will be published in https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.651.1 around 12:30 PM Pacific on Friday Sep 13th.

@trivikr
Copy link
Member

trivikr commented Sep 13, 2024

new version will be published in https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.651.1

Verified that issue is fixed in v3.651.1

$ test-install> npm install @aws-sdk/core@3.651.1 --save-exact

$ test-install> ls -1a node_modules/@aws-sdk/core/dist-es/submodules/httpAuthSchemes/aws_sdk
.
..
AwsSdkSigV4ASigner.js
AwsSdkSigV4Signer.js
index.js
resolveAwsSdkSigV4AConfig.js
resolveAwsSdkSigV4Config.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1 This is a high priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants