Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates named shadow to add AWS Service limit checks #72

Merged
merged 7 commits into from
Feb 2, 2021

Conversation

leegeth
Copy link
Contributor

@leegeth leegeth commented Jan 30, 2021

Description of changes:
Add checks in Shadow library for the Shadow name length and Thing name length limits as documented in https://docs.aws.amazon.com/general/latest/gr/iot-core.html#device-shadow-limits.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@leegeth leegeth requested a review from archigup February 1, 2021 17:45
source/shadow.c Outdated Show resolved Hide resolved
source/shadow.c Outdated Show resolved Hide resolved
archigup
archigup previously approved these changes Feb 1, 2021
@leegeth leegeth changed the title Updates/named shadow Updates named shadow to add AWS Service limit checks Feb 1, 2021
Copy link
Contributor

@gkwicker gkwicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

source/shadow.c Outdated Show resolved Hide resolved
source/shadow.c Outdated Show resolved Hide resolved
source/shadow.c Outdated Show resolved Hide resolved
source/shadow.c Outdated Show resolved Hide resolved
source/shadow.c Show resolved Hide resolved
source/shadow.c Outdated Show resolved Hide resolved
source/shadow.c Outdated Show resolved Hide resolved
source/shadow.c Outdated Show resolved Hide resolved
source/shadow.c Outdated Show resolved Hide resolved
test/unit-test/shadow_utest.c Show resolved Hide resolved
gkwicker
gkwicker previously approved these changes Feb 2, 2021
source/shadow.c Show resolved Hide resolved
source/shadow.c Outdated Show resolved Hide resolved
@leegeth leegeth merged commit 3090e89 into aws:main Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants