Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This page crashed. URI malformed #9519

Closed
DJStompZone opened this issue Aug 29, 2023 · 7 comments
Closed

This page crashed. URI malformed #9519

DJStompZone opened this issue Aug 29, 2023 · 7 comments
Labels
frontend The React app and the infrastructure that supports it needs-upstream-help Not actionable without help from a service provider question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@DJStompZone
Copy link

Are you experiencing an issue with...

shields.io

🐞 Description

When using the badge maker/tester UI at https://shields.io/badges, the page instantly crashes if the user attempts to input an emoji into the topmost field, showing the message "This page crashed. URI malformed"

🔗 Link to the badge


💡 Possible Solution

Something's presumably choking on extra-long unicode characters such as emojis. Will investigate further

@DJStompZone DJStompZone added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Aug 29, 2023
@chris48s
Copy link
Member

I just tried to reproduce this and I am not seeing this issue

Screenshot at 2023-08-29 17-34-16

Are you able to provide any additional info? Whta browser/OS are you using? I'd guess this might be something that only affects a subset of browsers?

@chris48s chris48s added the frontend The React app and the infrastructure that supports it label Aug 29, 2023
@DJStompZone
Copy link
Author

So far I've only reproduced this bug on Microsoft Edge (Version 114.0.1823.36 64-bit) on Xbox One, I can check to see if there's any other browsers that do it as well. I've tested it on Chrome 114 on Android 9 and was unable to reproduce.

@DJStompZone
Copy link
Author

DJStompZone commented Aug 30, 2023

Update, the crash only occurs when typing in an emoji in the box, if I paste a complete set of params all at once such as 🤨-interesting-blue it works fine and doesn't crash.
Upon further inspection, even when I paste in 🤨 by itself, it doesn't crash. It only seems to happen using the system UI to enter an emoji though the built-in emoji keyboard. I'm going to have to check to see if this occurs on other Windows environments with similar keyboards such as Windows 10.
Will update with any new info.

@jNullj
Copy link
Collaborator

jNullj commented Sep 6, 2023

Cool, was able to reproduce on win10 just now, I did not have an issue with regular emoji or win+. emoji
It only happend when using the on-screen keyboard, i use it lots for VR. It happends on edge and chrome

edit: confirmed for firefox
My intuition tells me its something with docusaurus/its plugins but i can't tell yet, might be related to shields.io implementation as well.

@jNullj
Copy link
Collaborator

jNullj commented Sep 6, 2023

Was able to confirm it in the demo of https://github.com/cloud-annotations/docusaurus-openapi plugin we use:

  1. go to the demo at https://docusaurus-openapi.netlify.app/cos/create-a-bucket
  2. Insert emoji using the built in on screen win10 keyboard in the first input field on the side menu
  3. Same issue:
    image
    I will open an issue on the plugin repo

@jNullj
Copy link
Collaborator

jNullj commented Sep 6, 2023

I found the bug on docusaurus-openapi, this is the result of onInput for UTF-16 encoded emoji by the keyboard, The current on input solution tries to translate those to URI which fails and results in this error. I will PR a solution today or tomorrow.

@chris48s chris48s added the needs-upstream-help Not actionable without help from a service provider label Sep 10, 2023
@chris48s
Copy link
Member

This took longer than I wanted it to, but the fix for this is now deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The React app and the infrastructure that supports it needs-upstream-help Not actionable without help from a service provider question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

3 participants