From 3407607e9a9d9ed55139a72e41d26c2bf0154076 Mon Sep 17 00:00:00 2001 From: chris48s Date: Mon, 31 Jul 2023 10:44:05 +0100 Subject: [PATCH 1/5] bring GH downloads/release errors into line --- services/github/github-downloads.service.js | 2 +- services/github/github-downloads.tester.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/services/github/github-downloads.service.js b/services/github/github-downloads.service.js index 346f55298a994..69c28492c7558 100644 --- a/services/github/github-downloads.service.js +++ b/services/github/github-downloads.service.js @@ -247,7 +247,7 @@ export default class GithubDownloads extends GithubAuthV3Service { } if (releases.length === 0) { - throw new NotFound({ prettyMessage: 'no releases' }) + throw new NotFound({ prettyMessage: 'no releases found' }) } const { downloads } = this.constructor.transform({ diff --git a/services/github/github-downloads.tester.js b/services/github/github-downloads.tester.js index dfee08ad7aea5..11f833c947f29 100644 --- a/services/github/github-downloads.tester.js +++ b/services/github/github-downloads.tester.js @@ -19,11 +19,11 @@ t.create('Downloads all releases') t.create('Downloads all releases (no releases)') .get('/downloads/badges/shields/total.json') - .expectBadge({ label: 'downloads', message: 'no releases' }) + .expectBadge({ label: 'downloads', message: 'no releases found' }) t.create('Downloads-pre all releases (no releases)') .get('/downloads-pre/badges/shields/total.json') - .expectBadge({ label: 'downloads', message: 'no releases' }) + .expectBadge({ label: 'downloads', message: 'no releases found' }) t.create('Downloads all releases (repo not found)') .get('/downloads/badges/helmets/total.json') @@ -154,7 +154,7 @@ t.create('downloads-pre for latest release') // https://github.com/badges/shields/issues/3786 t.create('downloads-pre for latest release (no-releases)') .get('/downloads-pre/badges/shields/latest/total.json') - .expectBadge({ label: 'downloads', message: 'no releases' }) + .expectBadge({ label: 'downloads', message: 'no releases found' }) t.create('downloads for release without slash') .get('/downloads/atom/atom/v0.190.0/total.json') From d9fba263e2b8e1757124d079f31f8cc1cce2eb5b Mon Sep 17 00:00:00 2001 From: chris48s Date: Mon, 31 Jul 2023 10:44:34 +0100 Subject: [PATCH 2/5] update GH lerna test example --- services/github/github-lerna-json.tester.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/services/github/github-lerna-json.tester.js b/services/github/github-lerna-json.tester.js index d4097a99c9673..95694ee27d72a 100644 --- a/services/github/github-lerna-json.tester.js +++ b/services/github/github-lerna-json.tester.js @@ -7,12 +7,10 @@ t.create('Lerna version').get('/facebook/jest.json').expectBadge({ message: isSemver, }) -t.create('Lerna version (independent)') - .get('/jneander/jneander.json') - .expectBadge({ - label: 'lerna', - message: 'independent', - }) +t.create('Lerna version (independent)').get('/imba/imba.json').expectBadge({ + label: 'lerna', + message: 'independent', +}) t.create('Lerna version (branch)').get('/facebook/jest/main.json').expectBadge({ label: 'lerna@main', From 10806d7df4339beed7f4a559b8221ff76c89ce0b Mon Sep 17 00:00:00 2001 From: chris48s Date: Mon, 31 Jul 2023 10:45:07 +0100 Subject: [PATCH 3/5] update GH package.json test example --- services/github/github-package-json.tester.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/github/github-package-json.tester.js b/services/github/github-package-json.tester.js index 7ba422d534da5..28fa94408f5f4 100644 --- a/services/github/github-package-json.tester.js +++ b/services/github/github-package-json.tester.js @@ -93,9 +93,9 @@ t.create('Prod dependency version (monorepo)') }) t.create('Scoped dependency') - .get('/dependency-version/badges/shields/dev/@babel/core.json') + .get('/dependency-version/badges/shields/dev/@docusaurus/core.json') .expectBadge({ - label: '@babel/core', + label: '@docusaurus/core', message: semverRange, }) From dbfa8220bb0829dc1a2cef95021c00f8fd46026e Mon Sep 17 00:00:00 2001 From: chris48s Date: Mon, 31 Jul 2023 10:45:30 +0100 Subject: [PATCH 4/5] update GH pipenv test example --- services/github/github-pipenv.tester.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/github/github-pipenv.tester.js b/services/github/github-pipenv.tester.js index 50b74f12b9356..578a85c91b95c 100644 --- a/services/github/github-pipenv.tester.js +++ b/services/github/github-pipenv.tester.js @@ -82,8 +82,10 @@ t.create('Locked version of unknown dependency') }) t.create('Locked version of VCS dependency') - .get('/locked/dependency-version/GSS-Cogs/databaker-docker/databaker.json') + .get( + '/locked/dependency-version/thorn-oss/perception/dev/videoalignment.json', + ) .expectBadge({ - label: 'databaker', + label: 'videoalignment', message: isShortSha, }) From 13ca8786eb9b612a41583d6fcd4712db005e39af Mon Sep 17 00:00:00 2001 From: chris48s Date: Mon, 31 Jul 2023 10:46:01 +0100 Subject: [PATCH 5/5] update GH search test assertion --- services/github/github-search.tester.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/github/github-search.tester.js b/services/github/github-search.tester.js index cb3fa80564a1c..a220560a63d6b 100644 --- a/services/github/github-search.tester.js +++ b/services/github/github-search.tester.js @@ -8,4 +8,4 @@ t.create('hit counter') t.create('hit counter for nonexistent repo') .get('/badges/puppets/async%20handle.json') - .expectBadge({ label: 'counter', message: 'repo not found' }) + .expectBadge({ label: 'async handle counter', message: '0' })