Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Overlapping] Improve market price input #1322

Open
2 of 4 tasks
GrandSchtroumpf opened this issue Jul 1, 2024 · 0 comments
Open
2 of 4 tasks

[Overlapping] Improve market price input #1322

GrandSchtroumpf opened this issue Jul 1, 2024 · 0 comments
Assignees

Comments

@GrandSchtroumpf
Copy link
Collaborator

GrandSchtroumpf commented Jul 1, 2024

  • edit price - do not default into price field when price is available
    flow:
  1. click edit price
  2. IF external price is available, do not default into the price field (because it force to show the last bit of the price which is usually a number that doesnt make sense)
Screen.Recording.2024-07-01.at.14.24.48.mov
  • external price - decimal trim
    currently, we show 82 decimals.
    updated, show the following:
    IF (first 6 decimals are 0) AND (price < 1), show the 6 decimals after the first non zero digit
    ELSE, show 6 decimals

  • edit market price when there is no external price
    currently warning:
    Warning, your market price will be used in the strategy creation flow and calculations.

updated warning:
Warning, the defined market price will be used for strategy budget distribution

image
  • edit strategy with no external price
    flow:
  1. edit a strategy with no external price
  2. show the price input modal
image 3. in the place where we typically show "use market" and allow users to click and use the external market price, replace it with "use strategy" and allow users to click and use the strategy geomean(marginal.sell, marginal.buy) 4. add tool tip when mouse over "use strategy" with this text: "This price is the geometric mean of the strategy buy and sell marginal prices."
@GrandSchtroumpf GrandSchtroumpf self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant