Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require_paths attribute does not work #97

Closed
ash2k opened this issue May 13, 2021 · 1 comment · Fixed by #102
Closed

require_paths attribute does not work #97

ash2k opened this issue May 13, 2021 · 1 comment · Fixed by #102
Labels
rule::ruby_bundle

Comments

@ash2k
Copy link

ash2k commented May 13, 2021

rules_ruby/ruby/private/gemspec/def.bzl

Line 101 in b738b98

"{gem_require_paths}": repr(["lib"]),
hard codes it to lib.
@mmizutani mmizutani mentioned this issue Jul 4, 2021
Merged
@kigster kigster linked a pull request Jul 7, 2021 that will close this issue
Add includes option to ruby_bundle rule for per-gem load path customization #102
Merged
@kigster
Copy link
Contributor

kigster commented Jul 8, 2021

Yes, it's a known limitation — thank you for taking on the enhancement and let me know if you want any help.

We can remote pair on this if you like.

@kigster kigster added rule::ruby_bundle work-in-progress This is not yet ready for review labels Jul 8, 2021
@kigster kigster removed the work-in-progress This is not yet ready for review label Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule::ruby_bundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add includes option to ruby_bundle rule for per-gem load path customization mmizutani/rules_ruby
2 participants
@ash2k @kigster