You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The errors started appearing due to the bump in eslint import plugin version. There was a bug with the babel-eslint parser not reporting the errors. The errors reported already existed before the dependency update in #1597, but were not reported.
The warnings are a false negative. Whilst there is a circular dependancy due to the internal link requiring the routes regex to match against, this only imports a constant and therefore isn't a true circular dependency.
However to improve readability, the regex paths have been moved to separate file that the routes and internal link component can share without eslint flagging a circular dependency.
Describe the bug
In #1597 we updated our dependencies but had to add to temporarily disable
import/no-cycle
in.eslintrc.js
.This is because with that warning enabled we now get 10 errors of the form:
We should re-enable the linter rule and fix the errors.
To Reproduce
Steps to reproduce the behavior:
import/no-cycle
from .eslintlrcnpm run test:lint
Expected behavior
No linter errors should be shown.
Screenshots
NA
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: