Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User cannot see who actually is logged in. #361

Closed
SimonSimCity opened this issue Mar 26, 2024 · 16 comments · Fixed by #465
Closed

User cannot see who actually is logged in. #361

SimonSimCity opened this issue Mar 26, 2024 · 16 comments · Fixed by #465
Labels
help wanted Community can help with implementing this

Comments

@SimonSimCity
Copy link
Collaborator

A user cannot see whether its him or another person who is logged in. This becomes problematic on shared devices.

The current website solves this issue by using the topbar.

@SimonSimCity
Copy link
Collaborator Author

SimonSimCity commented Mar 26, 2024

Issue might be resolved together with #360...

@kkuepper
Copy link
Member

Screenshot 2024-04-17 at 10 56 51 AM

This is not enough? But I guess most people don't have a profile picture.
Maybe we could show the initials if no picture is set.

@SimonSimCity
Copy link
Collaborator Author

SimonSimCity commented Apr 29, 2024

... and show the full name maybe on hover as a tooltip? Might just need another option to show it on a device which doesn't support hover (e.g. surface). Showing the name in the dropdown which opens clicking on the profile is also sufficient to me. Just some place I can see the full name.

@sifferhans
Copy link
Collaborator

We could also replace the "Profile" text with the name. Maybe less obvious that you can click it that way, but I think it is quite a normal pattern

@sifferhans
Copy link
Collaborator

sifferhans commented Jun 24, 2024

@kkuepper @SimonSimCity Here are a couple of ideas:

CleanShot 2024-06-24 at 15 27 32@2x

CleanShot 2024-06-24 at 15 29 06@2x

I kinda like the first one better aesthetically. I just use user.username from the useUser composable for now, but it might be better to have a name instead of the email.

@kkuepper
Copy link
Member

Another option would be to change the "Sign out" button to "Sign out Sigve Hansen".

@sclausendk Do you want to make a design or should we just decide?

@sclausendk
Copy link

I'll come up with a design.

@sclausendk
Copy link

@kkuepper @SimonSimCity Here are a couple of ideas:

CleanShot 2024-06-24 at 15 27 32@2x

CleanShot 2024-06-24 at 15 29 06@2x

I kinda like the first one better aesthetically. I just use user.username from the useUser composable for now, but it might be better to have a name instead of the email.

I really like the first one, but we should emphasize the name, and have the email as secondary.

@sifferhans If you switch the styling around, so the first line of text is emphasized, and then change that line to being the Name, we should be good 👍
Does that make sense?

@sifferhans
Copy link
Collaborator

@sclausendk More like this?

CleanShot 2024-06-24 at 22 21 12@2x

@sclausendk
Copy link

@sifferhans Spot on! 👏🏼

@sifferhans
Copy link
Collaborator

sifferhans commented Jun 25, 2024

@kkuepper Then we need access to the users name somehow. The UserModel we get from the SDK only contains the username, which is the email in this case.

Edit: nevermind, I can get it from useAuth0

@sifferhans
Copy link
Collaborator

@sclausendk Would it also make sense to move the "Sign out" button closer to the user information? Kinda makes sense in my mind to put these closer to each other as they are quite related.

CleanShot 2024-06-25 at 15 40 34@2x

Might be easier to accidentally click it then, though

@kkuepper kkuepper added help wanted Community can help with implementing this and removed missing design spec labels Jun 25, 2024
@kkuepper kkuepper linked a pull request Jun 25, 2024 that will close this issue
@kkuepper
Copy link
Member

kkuepper commented Jun 25, 2024

Auth0 provides the Display name and email address (see #467 or temporary website).

@sclausendk
Copy link

sclausendk commented Jun 26, 2024

@sifferhans I think that makes sense. But the hierarchy becomes a bit unclear.
I would suggest something like this:
image

Although this might not scale well with long names, and certain languages (Sign out, Logg ut, Cerrar la sesión, Abmelden, Disconnettersi).

We could consider making the menu a bit wider so mitigate this issue:
image

@SimonSimCity
Copy link
Collaborator Author

... and keep in mind that names sometimes are quite long, and mail addresses too...

@sclausendk
Copy link

@SimonSimCity Agree. But keep in mind that seeing 90% of your email address, is enough to identify which user you are on :) I think the above will work well for 95% of all names and emails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community can help with implementing this
Projects
None yet
4 participants