Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Legolas.write_full_path and related behavior that uses it #31

Open
jrevels opened this issue Jan 19, 2022 · 0 comments
Open

Comments

@jrevels
Copy link
Member

jrevels commented Jan 19, 2022

ref #26 (comment)

Actually, you know what - maybe we should just deprecate this function entirely. Why is Legolas in the business of creating intermediate paths for users at all? why not follow Base's lead and puts the onus on the caller to use mkpath beforehand if they need it?

Legolas' behavior is of course convenient when it's what you want, but maybe it really is generally more user-friendly (and at least more common) to error for local filesystem paths if they don't have the directories already made (and this shouldn't matter for S3Paths anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant