Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests as follow-up to abstract vector support #90

Open
hannahilea opened this issue Jun 7, 2023 · 1 comment
Open

Add tests as follow-up to abstract vector support #90

hannahilea opened this issue Jun 7, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@hannahilea
Copy link
Contributor

Following #89,

add more tests for this as a followup, to cover the changed lines and ensure we don't regress

(ref #89 (comment))

@ararslan
Copy link
Member

I think the tests added in #96 actually cover the changes made in #89, somewhat on purpose. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants