Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable documentation is updated with pre-releases #185

Closed
omus opened this issue Oct 5, 2023 · 2 comments · Fixed by #220
Closed

Stable documentation is updated with pre-releases #185

omus opened this issue Oct 5, 2023 · 2 comments · Fixed by #220
Assignees

Comments

@omus
Copy link
Member

omus commented Oct 5, 2023

At the moment we use tags to trigger the "Documenter" workflow which ends up deploying our "stable" documentation. As this repo will create tags for pre-releases this is problematic as we may replace our stable documentation well before we intend to make an official Julia registry release.

We can most likely address this by updating the "Documenter" workflow to not build based upon tags but rather use the "release" event which would allow us to only trigger on non-pre-releases. We would need to verify that works with deploydocs(; versions) but I suspect it would.

This discussion provides some good instructions on pre-release events: https://github.com/orgs/community/discussions/26281#discussioncomment-3251177

@ericphanson
Copy link
Member

Versions is only for the nav drop-down, not the trigger. There’s tag_prefix to customize tag triggers but that’s still for a tag.

@glennmoy glennmoy self-assigned this Oct 26, 2023
@glennmoy
Copy link
Contributor

glennmoy commented Nov 1, 2023

github has a released type event that should allow us to trigger this https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release

@kleinschmidt kleinschmidt linked a pull request Nov 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants