NaN is given as ratio when the previous value is 0

[miparnisari]

If a previous benchmark is 0, don't try to divide here

github-action-benchmark/src/write.ts

Lines 179 to 181 in a229668

	const ratio = biggerIsBetter(curSuite.tool)
	? prev.value / current.value // e.g. current=100, prev=200
	: current.value / prev.value;

or here

github-action-benchmark/src/write.ts

Lines 575 to 577 in a229668

	const ratio = biggerIsBetter(config.tool)
	? previousBench.value / bench.value
	: bench.value / previousBench.value;

or here

github-action-benchmark/src/write.ts

Lines 107 to 109 in a229668

	const ratio = biggerIsBetter(curSuite.tool)
	? prev.value / current.value // e.g. current=100, prev=200
	: current.value / prev.value; // e.g. current=200, prev=100

(Why are there three places doing a division? 😆 )

[ktrz]

Hi @miparnisari

I've created a PR #222 to address this. I went for a solution that is not mathematically correct but I think it still gives good information IMO:

• display 1 as ratio if both values are 0
• display +∞ or -∞ if division results in Infinity or -Infinity (this happens in JS when the divisor is 0 but the dividend is non-0)

What do you think of this solution?

[ktrz]

released in v1.19.3