Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA_OAuthTwitterEngine _sendRequestWithMethod:.... fails to apply params on GET #80

Open
tblanchard opened this issue Jul 26, 2011 · 0 comments

Comments

@tblanchard
Copy link

I was trying to add a method to implement followers/ids.json which is a GET. Tracing the code I find

// --------------------------------------------------------------------------------
// modificaiton from the base clase
// the base class appends parameters here
// --------------------------------------------------------------------------------

and then the code that does it is commented out. But there is nowhere in this method where params gets used unless you are doing a POST. Since the convention is to pass nil for method: when it is a GET, I added the following code here.

if (!method && params) {
        fullPath = [self _queryStringWithBase:fullPath parameters:params prefixed:YES];
}

and now things work as expected. I don't understand how it was supposed to have worked at all for GET requests.

Otherwise your sample project was great and really helped me get going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant