Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuild fails when total error limit is reached #31

Open
PShchegolevatykh opened this issue Oct 12, 2017 · 0 comments
Open

MSBuild fails when total error limit is reached #31

PShchegolevatykh opened this issue Oct 12, 2017 · 0 comments

Comments

@PShchegolevatykh
Copy link

PShchegolevatykh commented Oct 12, 2017

Hi Ben,

Thank you for the library. It's been working great except one thing. When the error amount exceeds default it fails the build with an error:

Total JSLint: error limit reached: 1001

Currently, I'd prefer not to fail the build at all. I'd like to show everything as warnings. I set "output": "Warning" in my JSLintNet.json and in my target I changed Error block to warning like so:

 <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
    <PropertyGroup>
      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
    </PropertyGroup>
    <Warning Condition="!Exists('..\..\packages\JSLintNet.MSBuild.2.3.0\build\JSLintNet.MSBuild.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\JSLintNet.MSBuild.2.3.0\build\JSLintNet.MSBuild.targets'))" />
  </Target>

It still shows "Total JSLint: error limit reached" as an error. Is this a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant