Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: shadows are broken-looking in lighting example #7397

Closed
rparrett opened this issue Jan 28, 2023 · 3 comments
Closed

wasm: shadows are broken-looking in lighting example #7397

rparrett opened this issue Jan 28, 2023 · 3 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Milestone

Comments

@rparrett
Copy link
Contributor

rparrett commented Jan 28, 2023

Bevy version

main

Relevant system information

chrome

AdapterInfo { name: "ANGLE (Apple, Apple M1 Max, OpenGL 4.1)", vendor: 4203, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Gl }

What you did

with wasm-server-runner
cargo run --example lighting --target=wasm32-unknown-unknown

What went wrong

image

Additional information

The shadow cascades are adjusted for this example, but in a way that breaks them on wasm due to num_cascades being > 1.

load_gltf may be broken too, but if it is, it's less obvious.

Both of these examples are built for https://bevyengine.org/examples/

related: #7362

@rparrett rparrett added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jan 28, 2023
@rparrett rparrett changed the title wasm: shadows are broken-looking in lighting examples wasm: shadows are broken-looking in lighting example Jan 28, 2023
@JMS55 JMS55 added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Jan 28, 2023
@JMS55 JMS55 added this to the 0.10 milestone Jan 28, 2023
@danchia
Copy link
Contributor

danchia commented Jan 28, 2023

Ah yes, I always forget about wasm :( The cascades default settings account for it, but not the examples

@danchia
Copy link
Contributor

danchia commented Jan 28, 2023

Maybe the right thing to do for WASM is to also do the clamping in the cascades config constructor - that way we'll at least we can use the far bound.

@rparrett
Copy link
Contributor Author

rparrett commented Feb 6, 2023

Fixed by #7456

@rparrett rparrett closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

No branches or pull requests

3 participants