From bd7973eafdf3ae5205dc765a5dbdd92b48e5a420 Mon Sep 17 00:00:00 2001 From: William Batista Date: Sat, 16 Oct 2021 11:49:10 -0400 Subject: [PATCH 1/4] Switched TODO commment --- crates/bevy_render/src/texture/image_texture_conversion.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/bevy_render/src/texture/image_texture_conversion.rs b/crates/bevy_render/src/texture/image_texture_conversion.rs index dc31be26d5e6b..5fd4ffba1bb9d 100644 --- a/crates/bevy_render/src/texture/image_texture_conversion.rs +++ b/crates/bevy_render/src/texture/image_texture_conversion.rs @@ -87,7 +87,7 @@ impl From for Texture { Vec::with_capacity(width as usize * height as usize * format.pixel_size()); for pixel in image.into_raw().chunks_exact(3) { - // TODO unsafe_get in release builds? + //TODO use the array_chunks method once stabilised let r = pixel[0]; let g = pixel[1]; let b = pixel[2]; From 5649d3a50f95c5da2736e43da64c9ef4ee0d82f8 Mon Sep 17 00:00:00 2001 From: William Batista Date: Sun, 17 Oct 2021 14:53:41 -0400 Subject: [PATCH 2/4] Changed comment in bevy_render2 --- pipelined/bevy_render2/src/texture/image_texture_conversion.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pipelined/bevy_render2/src/texture/image_texture_conversion.rs b/pipelined/bevy_render2/src/texture/image_texture_conversion.rs index 862ff5ee58447..b1f49797a4955 100644 --- a/pipelined/bevy_render2/src/texture/image_texture_conversion.rs +++ b/pipelined/bevy_render2/src/texture/image_texture_conversion.rs @@ -87,7 +87,7 @@ pub(crate) fn image_to_texture(dyn_img: image::DynamicImage) -> Image { Vec::with_capacity(width as usize * height as usize * format.pixel_size()); for pixel in image.into_raw().chunks_exact(3) { - // TODO unsafe_get in release builds? + //TODO use the array_chunks method once stabilised let r = pixel[0]; let g = pixel[1]; let b = pixel[2]; From 4a2f6636f28671379061435716e18285a60aa133 Mon Sep 17 00:00:00 2001 From: William Batista Date: Wed, 20 Oct 2021 07:56:29 -0400 Subject: [PATCH 3/4] Formatting + linked array_chunks tracking issue --- crates/bevy_render/src/texture/image_texture_conversion.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/bevy_render/src/texture/image_texture_conversion.rs b/crates/bevy_render/src/texture/image_texture_conversion.rs index 5fd4ffba1bb9d..ab8fbc0646f87 100644 --- a/crates/bevy_render/src/texture/image_texture_conversion.rs +++ b/crates/bevy_render/src/texture/image_texture_conversion.rs @@ -87,7 +87,8 @@ impl From for Texture { Vec::with_capacity(width as usize * height as usize * format.pixel_size()); for pixel in image.into_raw().chunks_exact(3) { - //TODO use the array_chunks method once stabilised + // TODO use the array_chunks method once stabilised + // https://github.com/rust-lang/rust/issues/74985 let r = pixel[0]; let g = pixel[1]; let b = pixel[2]; From d55db6c40b60fbb6345b4aabef6602bd78f9c5b9 Mon Sep 17 00:00:00 2001 From: William Batista Date: Wed, 20 Oct 2021 08:41:59 -0400 Subject: [PATCH 4/4] Added comment for bevy_render2 --- pipelined/bevy_render2/src/texture/image_texture_conversion.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pipelined/bevy_render2/src/texture/image_texture_conversion.rs b/pipelined/bevy_render2/src/texture/image_texture_conversion.rs index b1f49797a4955..85126f23c2151 100644 --- a/pipelined/bevy_render2/src/texture/image_texture_conversion.rs +++ b/pipelined/bevy_render2/src/texture/image_texture_conversion.rs @@ -87,7 +87,8 @@ pub(crate) fn image_to_texture(dyn_img: image::DynamicImage) -> Image { Vec::with_capacity(width as usize * height as usize * format.pixel_size()); for pixel in image.into_raw().chunks_exact(3) { - //TODO use the array_chunks method once stabilised + // TODO use the array_chunks method once stabilised + // https://github.com/rust-lang/rust/issues/74985 let r = pixel[0]; let g = pixel[1]; let b = pixel[2];