-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If offline show last online timestamp #76
Comments
That's an interesting point. I'll have to figure out a way to integrate this into the web UI cleanly. I'll do some research and come back with screenshots or samples here. |
On top, near the clock maybe. |
Problem is that there can be multiple people on a map at a time. One may be offline while another is still live. The red "Offline" that replaces the timer is an indicator that the map viewer is offline rather than the people sharing their locations. |
Oh, I didn't test multiple users yet. So the nicest solution would be to show it at each marker after all. |
Nice, though it won't be an arrow I guess? |
It would be a circle that indicates no movement. The arrow is just there because of the GPS emulator I'm using to not disclose my location here. :-) |
This is live; you can pull the latest version from Docker Hub in about 20 minutes or so. |
Just updated, not Docker, interior setting (so no GPS location on start), app says green "Location sharing active!" but GPS Test shows no lock (I guess same as #80). Anyway, I get the circle and the OFFLINE, but no time. I guess it's because it didn't actually get a "last lock time"? |
If you get the green "Location service active" then that means that the app has found a GPS fix. That said, it might not be continuously receiving them any more. The "Offline" text actually isn't in the code any more. Could you try to clear cache in your browser/any caching providers (CloudFlare etc.) and see if that helps? |
Ok, works now after several forced reloads. Thanks |
Built app from HEAD too, noticed that it mostly says "2min ago", is this some rounding error? I've disconnected the internet connections and appears to work ok, eg. 10 min have passed and now says 10 mins. But online again, still "2min ago"... |
The timestamp of the last received data is fetched from the app and sent to the browser, where the browser compares to its local time. Can you confirm that both devices' clocks run in sync? |
Devices meaning Android and/or server and/or browser? /LE: You are right, browser is 2mins ahead :) :) |
Another odd thing, checking the other problematic share in the browser, while indoors w/o a lock, the text always said "2h ago", now I can guess where these 2h come from (server on UTC, client on local timezone), but while it had the GPS lock earlier, everything was ok (time wise at least). |
Both the app, frontend and backend all use Unix timestamps, so timezones won't be an issue. The "2h ago" would stem from there actually not being any updates for the past 2 hours received by the server. |
Actually thinking again, 2h might just be a the round off, eg. 2h55m will still be 2h, right? I'm not sure I was there >3 h. Will have to retest somehow... |
Yes, it rounds down. 2h55m will still show as 2h. It switches to 3h once it reaches 3h00m. |
..."offline since XXXX" or "offline for the last XXXX sec/min"
The text was updated successfully, but these errors were encountered: