Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow O / 0 in the IDs #91

Closed
iMartyn opened this issue Dec 10, 2019 · 2 comments
Closed

Don't allow O / 0 in the IDs #91

iMartyn opened this issue Dec 10, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@iMartyn
Copy link

iMartyn commented Dec 10, 2019

I know the mixed case scheme doesn't use l and I but the first ever link I got contained an O and an 0!

It'd be nice to stop that from happening too.

@bilde2910
Copy link
Owner

That's a pretty good point, actually. I'll make sure to change the dictionary space so it can't contain O or 0. This does reduce the number of possible combinations by about 37%, but still maintains long enough time to bruteforce on the default setting (~28 years @ 1000/sec) that it shouldn't matter significantly for security in practice. I'll get this included in v1.6.

@bilde2910 bilde2910 added the enhancement New feature or request label Dec 10, 2019
@bilde2910
Copy link
Owner

Removed 0 and O from the character pool for upper- and mixed-case IDs.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants