Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split session expired and pressed button to stop messages #95

Closed
licaon-kter opened this issue Dec 11, 2019 · 3 comments
Closed

Split session expired and pressed button to stop messages #95

licaon-kter opened this issue Dec 11, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@licaon-kter
Copy link
Contributor

licaon-kter commented Dec 11, 2019

...in the current setup you get the same "Your location share has expired" message, which is rather odd to see when one presses the button to "Stop sharing"

I'd guess here and here

"Your location share has expired"
vs
"You have stopped sharing the location"

@bilde2910
Copy link
Owner

Would "Your location share has ended" work?

@licaon-kter
Copy link
Contributor Author

Yes, whatever you want it phrased. :)

@bilde2910
Copy link
Owner

Changed "expired" to "ended". "Expired" only works if if the share expired by itself; "ended" also works if the user stops it manually.

@bilde2910 bilde2910 added the enhancement New feature or request label Dec 11, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants