Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase from "Encrypted" #96

Closed
licaon-kter opened this issue Dec 11, 2019 · 9 comments
Closed

Rephrase from "Encrypted" #96

licaon-kter opened this issue Dec 11, 2019 · 9 comments
Labels
enhancement New feature or request

Comments

@licaon-kter
Copy link
Contributor

...to "Password protected", as that's the right description of its function anyway.

@bilde2910
Copy link
Owner

bilde2910 commented Dec 12, 2019

In which contexts? All contexts in which "encrypt" shows up?

Password protected shares are actually encrypted using AES-256 so the phrasing is accurate; rephrasing it would depend on whether that's a good idea from a UX perspective. Do you think it'd be better UX to say "password protected" rather than "encrypted"? (I'm no UX expert myself)

@bilde2910
Copy link
Owner

You know, come to think of it, you have a point. It's better to describe the result than the process. Particularly for less tech savvy end users, it's better to tell them that they have to enter a password because it's password protected, rather than trying to make them understand encryption. Everyone knows what a password is anyway. I'll see if I can make this change tomorrow.

@licaon-kter
Copy link
Contributor Author

All the passwords are encrypted somewhere (we don't care, we hope they are), but the actual sharing link is just "password protected".

@bilde2910 bilde2910 added the enhancement New feature or request label Dec 12, 2019
@licaon-kter
Copy link
Contributor Author

Also push these changes to the translation portal. Thanks

@bilde2910
Copy link
Owner

bilde2910 commented Dec 12, 2019

The changes are pushed to the portal already. The strings "Enable end-to-end encryption" and "Disable end-to-end encryption" are kept as-is as they are the helper text for the "Password protect share" option (which was changed).

image

You may refer to the commit above to see which strings were changed and pushed.

@licaon-kter
Copy link
Contributor Author

"end-to-end encryption" in the lines of https://en.wikipedia.org/wiki/End-to-end_encryption

So you say that the server doesn't know the actual location and stores the coords encrypted with the password? I didn't look in the code

@bilde2910
Copy link
Owner

That is correct. The data is encrypted here in the app and decrypted by the frontend. The backend has no idea what the data actually is and just has to pass it though without performing any validation or processing it in any way, as it doesn't have the key.

@haadr
Copy link

haadr commented Oct 31, 2020

That is correct. The data is encrypted here in the app and decrypted by the frontend. The backend has no idea what the data actually is and just has to pass it though without performing any validation or processing it in any way, as it doesn't have the key.

This is great to hear! I've been reading about Hauk before possibly giving it a try, and I saw on the screenshot that there's a reference to "end-to-end encryption", but I couldn't find anything about it in the FAQ.

Is this documented anywhere? If not, maybe it would be good to document it as it's a "killer feature" for many :)

@bilde2910
Copy link
Owner

This is great to hear! I've been reading about Hauk before possibly giving it a try, and I saw on the screenshot that there's a reference to "end-to-end encryption", but I couldn't find anything about it in the FAQ.

Is this documented anywhere? If not, maybe it would be good to document it as it's a "killer feature" for many :)

That's a good idea, actually. Didn't think about adding it to the FAQ, but I'll make sure to get that done soon.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants