Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 intelliJ plugin 1.0.0 doesn't lint and output the CLI help when formatting #41

Open
1 task done
cedeber opened this issue Mar 13, 2024 · 7 comments
Open
1 task done

Comments

@cedeber
Copy link

cedeber commented Mar 13, 2024

Environment information

CLI:
  Version:                      1.6.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.10.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.2.5"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

First, Using intelliJ on Windows with a project loaded via WSL or directly Windows, the Biome plugin seems to load successfully (LSP server says it is running) but it reports no linting issues (I saw them on VSCode for the same file)

Secondly, when I "format on save", it pastes the CLI output on the file. We can see that the formatting is done first, but then replaced by the help CLI output.

Expected result

lint and format properly ;-)

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico ematipico transferred this issue from biomejs/biome Mar 13, 2024
@cedeber
Copy link
Author

cedeber commented Apr 17, 2024

Looks like the v1.0.2 fixed the issue. We'll test a bit more and I close the ticket if everything is fine.

@cedeber
Copy link
Author

cedeber commented Apr 17, 2024

lineWidth from the config is not taking into account (if not the whole config file?) We set it explicitly in IntelliJ.

@cedeber
Copy link
Author

cedeber commented Apr 17, 2024

java.lang.Throwable: Failed to run Biome check with (format, safefixes) for file Whatever.tsx - \wsl.localhost\Ubuntu-22.04\home[..]/rome.json internalError/fs ━━━━━━━━━━━

× Biome couldn't read the file

× Biome couldn't read the following file, maybe for permissions reasons or it doesn't exists: \wsl.localhost\Ubuntu-22.04\home[..]/rome.json

PS: [..] being folder path here of the project (where package.json is).

@cedeber
Copy link
Author

cedeber commented Apr 17, 2024

Also reordering of import doesn't seem to work neither with 1.0.2

@cedeber
Copy link
Author

cedeber commented Apr 17, 2024

java.lang.Throwable: Failed to run Biome check with (format, safefixes) for file Whatever.tsx - \wsl.localhost\Ubuntu-22.04\home[..]/rome.json internalError/fs ━━━━━━━━━━━

× Biome couldn't read the file

× Biome couldn't read the following file, maybe for permissions reasons or it doesn't exists: \wsl.localhost\Ubuntu-22.04\home[..]/rome.json

PS: [..] being folder path here of the project (where package.json is).

I reopened the config and the link the biome.json path where changed to the folder of the app (where package.json is)
We have a workspace config if it may be the issue to test.

@Sec-ant
Copy link
Member

Sec-ant commented Apr 17, 2024

Would you mind updating Biome to the latest version (v1.7.0)?

@cedeber
Copy link
Author

cedeber commented Apr 17, 2024

I just did now, it's well detected regarding the status bar, but it's not better for the formatting.
Formatting also often times out btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants