Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bisq requesting permissions for keystrokes on all apps [osx catalina] #3373

Closed
lukemcgregor opened this issue Oct 8, 2019 · 24 comments
Closed
Labels
a:bug in:build in:gui is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation on:macOS

Comments

@lukemcgregor
Copy link

lukemcgregor commented Oct 8, 2019

When I first started bisq (v1.1.7) after upgrading to catalina, i got the following (disturbing) message:

Bisq would like to receive keystrokes from any application.

Repro:
Install bisq on OSX 10.15, run it. Shows permission request

Expected:
There is no reason bisq would need this permission I can see, so the permission shouldnt be requested

@ripcurlx
Copy link
Contributor

ripcurlx commented Oct 8, 2019

When I first started bisq after upgrading to catalina, i got the following (disturbing) message:

Bisq would like to receive keystrokes from any application.

I hope this is just a bug, not a keylogger of some kind

Repro:
Install bisq on OSX 10.15, run it. Shows permission request

Expected:
There is no reason bisq would need this permission I can see, so the permission shouldnt be requested

No I don't know why Bisq would need this functionality. I guess this is something that needs to be configured for macOS 10.15 in the javapackager. Thanks for bringing this up! Would be great if someone picks up this issue and does further investigation how to prevent this unnecessary permission request.

@lukemcgregor
Copy link
Author

lukemcgregor commented Oct 8, 2019

Theres not much online (i looked) and im not a java person, but this project also had the same issue:
wesnoth/wesnoth#4109

Theres also this bug in open JDK (not sure if you're using that or regular java) https://bugs.openjdk.java.net/browse/JDK-8231513

Now also this in SO
https://stackoverflow.com/questions/58094615/javafx-tornadofx-cause-keystroke-receiving-prompt-on-macos-10-15-catalina (upvoted)

When i searched it 20 mins ago there was less than 10 results now theres quite a few, im guessing its in a lib you are using.

This says the OpenJDK 11.0.4+11 packager will support hardening by default (which is a new catalina requirement) however I suspect it isn't the root cause of this. I think somewhere something is making a call to the wrong API, however updating the jdk version you use might correct this (looks like you are on 10 at the moment but there are some reasons you didnt upgrade yet from dev notes)
https://medium.com/adoptopenjdk/bundling-adoptopenjdk-into-a-notarized-macos-application-f4d69404afc

@ripcurlx
Copy link
Contributor

Yes, I hope there is a way to fix this without upgrading Java version as we are stuck at 10 because of the lack of javapacker support in newer versions. OpenJDK is working on it, but haven't finished it yet.

@shawnyeager
Copy link

shawnyeager commented Nov 5, 2019

At the risk of piling on, this was very jarring for me to see, as I just installed and launched for the first time. I was about to submit the same issue when I found this one. Blocking the permission request is trivial, but I'd suggest that the reputational damage among non-technical users will be heavy.

@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 8, 2019

At the risk of piling on, this was very jarring for me to see, as I just installed and launched for the first time. I was about to submit the same issue when I found this one. Blocking the permission request is trivial, but I'd suggest that the reputational damage among non-technical users will be heavy.

Yes this is something I'll focus now, as the big v1.2 release with all its aftermath is finally over.

@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 8, 2019

If it is the event tapping implementation of JavaFX we hopefully could get away with only updating the JavaFX libraries and not with the requirement to update to Java 11+

@1amico
Copy link

1amico commented Feb 4, 2020

I was about to submit the same issue when I found this one: I confirm that such a message scares enough, LOL!

image

@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Feb 18, 2020
@ripcurlx ripcurlx added the is:critical https://bisq.wiki/Critical_bug label Feb 18, 2020
@ripcurlx
Copy link
Contributor

ripcurlx commented Feb 20, 2020

It is fixed but not released already in openjfx14, but that requires at least JDK 11+. We were stuck until recently to JDK 10 because of the lack of JavaPackager, but it seems that there is progress made https://bugs.openjdk.java.net/browse/JDK-8200758 as well.

@cbeams cbeams added the a:bug label Feb 27, 2020
@lp74
Copy link

lp74 commented Jun 8, 2020

That's really intimidating.
I've stopped and deleted it.

@jim-obrien-orig
Copy link

This is unacceptable

@chimp1984
Copy link
Contributor

@ripcurlx Any update regarding JavaPackager?

@Brainfrazzle
Copy link

Brainfrazzle commented Aug 14, 2020

Sorry I got irritated. A currency trading app should most definitely not give any impression that it's trying to steal all your secrets. I understand it's not the developers fault, but I've removed the app. Even though I declined permission for logging all my keystrokes(!), it still installed itself as an option in the privacy and security options, on osx, unchecked but still. Good luck, again sorry to have initially been rude.

@chimp1984
Copy link
Contributor

@Brainfrazzle Its an OSX/Java issue, see discussion above.

@jobrienski
Copy link

So there is a workaround. Post-install you can remove the permission in your system settings. It doesn't actually use the permission, so it won't break the app.

@chimp1984
Copy link
Contributor

@jobrienski Can you explain more in details (I don't have that OSX version installed).
@ripcurlx Maybe we can apply some workaround until the javapackager is available?

@jobrienski
Copy link

You go to "settings>security&privacy>Input Monitoring" and uncheck Bisq.app.
Screen Shot 2020-08-16 at 7 06 02 PM

@chimp1984
Copy link
Contributor

Added a PR to address the issue: #4464

@coyr
Copy link

coyr commented Feb 21, 2021

We are in 2021 and the message still pop up. I am just learning about bisq and the message it is not encouraging too much

@ripcurlx
Copy link
Contributor

We are in 2021 and the message still pop up. I am just learning about bisq and the message it is not encouraging too much

Hi @coyr! This is fixed already for quite some time (months) in #4242, but unfortunately this PR is still pending because of some installer customizations for Windows. Should be ready for the next release if nothing unexpected pops up again.

@rogersentongo
Copy link

rogersentongo commented Feb 26, 2021

Just tried installing on my Mac and same popped up! Its 2021.
Update(It later on informs user to remove the option and why it's like that!)

@ra0x3
Copy link

ra0x3 commented May 4, 2021

Don't mean to pile on here, but also experiencing this after a fresh download

macOS Catalina 10.15.16

Obviously not the type of thing you want to see when you download any application let alone one not signed by Apple and involving money 😛

Really bad optics 👀

Update: I'm now seeing the "Due to stricter measures" popup. Which makes things even more sketch 😆

@ripcurlx
Copy link
Contributor

ripcurlx commented May 4, 2021

Don't mean to pile on here, but also experiencing this after a fresh download

macOS Catalina 10.15.16

Obviously not the type of thing you want to see when you download any application let alone one not signed by Apple and involving money 😛

Really bad optics 👀

Update: I'm now seeing the "Due to stricter measures" popup. Which makes things even more sketch 😆

If you run the v1.6.3 pre-release the problems should be gone already. The public release will be published soon.

@cd2357
Copy link
Contributor

cd2357 commented May 9, 2021

Should be fixed in the most recent release (v1.6.4) which includes notarization of the macOS binary. Please try it out and let us know if it's still an issue for you.

@cd2357 cd2357 closed this as completed May 9, 2021
@rgovindji
Copy link

I'm still getting this prompt and I am using version 1.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug in:build in:gui is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation on:macOS
Projects
None yet
Development

No branches or pull requests