Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 18 #688

Closed
ghubstan opened this issue Oct 22, 2020 · 7 comments
Closed

For Cycle 18 #688

ghubstan opened this issue Oct 22, 2020 · 7 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ghubstan
Copy link
Member

ghubstan commented Oct 22, 2020

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 11029.41
  • USD requested: 7500
  • BSQ rate: 0.68 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 17 #658

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Delete redundant core.api.StatusCheck dev 0 bisq-network/bisq#4606 merged
Change 'createoffer' api method return type dev 200 bisq-network/bisq#4554 merged
Build out 'createoffer' API method dev 1600 bisq-network/bisq#4559 merged
Tidy up CorePriceService (refactor) dev 0 bisq-network/bisq#4594 merged
Remove redundant DisputeAgentType enum dev 0 bisq-network/bisq#4595 merged
Simplify GrpcOffersService#createOffer (refactor) dev 500 bisq-network/bisq#4596 merged
Fix register dipute agent test assert dev 0 bisq-network/bisq#4605 merged
Add new 'getoffer offer-id' api method dev 500 bisq-network/bisq#4608 merged
Refactor offer/trade related classes in core and desktop dev 1500 bisq-network/bisq#4672 merged
Add 'takeoffer' API method dev 1500 bisq-network/bisq#4673 merged
Add 'confirmpaymentsent' api method dev 850 bisq-network/bisq#4674 merged
Add 'confirmpaymentreceived' api method dev 850 bisq-network/bisq#4675 merged
Changes suggested in PRs 4672,4673,4674,4675 dev 0 bisq-network/bisq#4679 merged

Also helped with release testing during this cycle.

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Use existing timer in unlockwallet(pwd, timeout) dev --- bisq-network/bisq#4558 merged
Block on tx-fee-request in core TakeOfferModel init dev --- bisq-network/bisq#4692 merged
Add fields to grpc TradeInfo proto & wrapper dev --- bisq-network/bisq#4696 merged
Replace TradeUtils with singleton TradeUtil dev --- bisq-network/bisq#4697 merged
Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil dev --- bisq-network/bisq#4699 merged
Refactor PendingTradesDataModel methods -> TradeUtil dev --- bisq-network/bisq#4700 merged
Add getRole(tradeId) to core api dev --- bisq-network/bisq#4701 merged
Refactor CLI output formatting code & add trade formatter dev --- bisq-network/bisq#4703 merged
Add 'gettrade' to api method CLI dev --- bisq-network/bisq#4704 merged
Add boolean 'showcontract' argument to api's 'gettrade' dev --- bisq-network/bisq#4705 merged
Stub out api methods 'keepfunds', 'withdrawfunds' dev --- bisq-network/bisq#4709 merged
Implement api methods 'keepfunds', 'withdrawfunds' dev --- bisq-network/bisq#4711 merged
Test trade closing api methods 'keepfunds', 'withdrawfunds' dev --- bisq-network/bisq#4712 merged
Stub out 'canceloffer' api method dev --- bisq-network/bisq#4713 merged
Implement 'canceloffer' api method dev --- bisq-network/bisq#4714 merged
Test 'canceloffer' api method dev --- bisq-network/bisq#4716 merged
Upgrade jupiterVersion = '5.7.0' dev --- bisq-network/bisq#4722 merged
Improve apitest cmd line console logging dev --- bisq-network/bisq#4723 merged
Refactor api test fixture setup dev --- bisq-network/bisq#4724 merged
Reduce apitest suite execution time dev --- bisq-network/bisq#4725 merged
Reduce apitest suite execution time dev --- bisq-network/bisq#4725 merged
Resolve issues found in reviewed PRs 4699, 4703, 4711 dev --- bisq-network/bisq#4731 merged
Define new grpc bsq/btc balances protos dev --- bisq-network/bisq#4793 awaiting review
Add proto wrappers for sending bsq, btc or all balances dev --- bisq-network/bisq#4794 awaiting review
Define proto for api method 'getunusedbsqaddress' dev --- bisq-network/bisq#4795 awaiting review
Define proto for api method 'sendbsq' dev --- bisq-network/bisq#4796 awaiting review
Add proto fields to support trade fee currency choice dev --- bisq-network/bisq#4797 awaiting review
Implement and test api method 'getunusedbsqaddress' dev --- bisq-network/bisq#4798 awaiting review
Implement and test new getbalance(s) api methods dev --- bisq-network/bisq#4799 awaiting review
Stub out api method 'sendbsq' in core dev --- bisq-network/bisq#4800 awaiting review
Refactor desktop's BsqSendView 'sendbsq', share with api dev --- bisq-network/bisq#4801 awaiting review
Support paying trade fees in bsq or btc in api dev --- bisq-network/bisq#4802 awaiting review
Delete deprecated api wallet test, adjust api build/run doc dev --- bisq-network/bisq#4803 awaiting review
Refactor getbalance api dev --- bisq-network/bisq#4808 awaiting review
Add api method 'getpaymentmethods' dev --- bisq-network/bisq#4818 awaiting review
Add api method 'getpaymentacctform' dev --- bisq-network/bisq#4819 awaiting review
Replace existing api method 'createpaymentacct' impl dev --- bisq-network/bisq#4821 awaiting review
Fix api's createpaymentacct validation problems dev --- bisq-network/bisq#4824 awaiting review
Add more 'createpaymentacct' api tests dev --- bisq-network/bisq#4828 awaiting review
Set country on MoneyGram acct in gson type adapter dev --- bisq-network/bisq#4834 awaiting review
Update bats api test dev --- bisq-network/bisq#4836 awaiting review
@ghubstan ghubstan changed the title [WIP] For Cycle 18 For Cycle 18 Oct 22, 2020
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Oct 22, 2020
@MwithM MwithM added this to the Cycle 18 milestone Oct 23, 2020
@ripcurlx
Copy link
Contributor

As I haven't reviewed this PRs: @sqrrm and @chimp1984 could you please provide your feedback on the requested amounts? Thanks!

@sqrrm
Copy link
Member

sqrrm commented Oct 24, 2020

I approve of this CR.

@chimp1984
Copy link

I have not reviewed that much, but what I had was all satisfying.

@ripcurlx
Copy link
Contributor

As stand in team lead I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@ghubstan
Copy link
Member Author

6a80e8b617fd472f034d6ca9c2b94d40434bfc8f8bb633364aa181c37110a81f

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Nov 8, 2020
@ghost
Copy link

ghost commented Nov 8, 2020

Issuance by Team:

team amount BSQ amount USD
dev 11029.41 7500.00

Total Issuance: 11029.41 BSQ (equivalent to: 7500.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Nov 8, 2020

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

5 participants