Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 28 #905

Closed
ghost opened this issue Aug 28, 2021 · 12 comments
Closed

For Cycle 28 #905

ghost opened this issue Aug 28, 2021 · 12 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ghost
Copy link

ghost commented Aug 28, 2021

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 625
  • USD requested: 950
  • BSQ rate: 1.52 USD per BSQ
  • Previous compensation request (if applicable): #

Compensation request for work done in Cycle 27.

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Fix incorrect tx link to tx explorer dev 300 bisq-network/bisq#5563
Wrong information popup after click on own offer dev 50 bisq-network/bisq#5564
Tooltip for unsigned accounts needs to provide more information dev 600 bisq-network/bisq#5569 Superseded, but a lot of work was done

Contributions in progress

bisq-network/bisq#5680

@ghost ghost changed the title [WIP] For Cycle 28 For Cycle 28 Sep 19, 2021
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Sep 19, 2021
@MwithM MwithM added this to the Cycle 28 milestone Sep 19, 2021
@ripcurlx
Copy link
Contributor

@xyzmaker123 Thanks for your contributions so far! Compared to other compensation requests I think the compensation requested for Fix incorrect tx link to tx explorer and Tooltip for unsigned accounts needs to provide more information are a little bit high.

@ghost
Copy link
Author

ghost commented Sep 20, 2021

@ripcurlx You're welcome. I decreased both items by 100USD

@ripcurlx
Copy link
Contributor

I still think Tooltip for unsigned accounts needs to provide more information is quite high, but I err in that case to approve it as this issue shouldn't have been marked as good first issue in the first place as of its JavaFX complexity. As dev team lead I approve this compensation request. Please submit your CR to the DAO for voting.

@ghost
Copy link
Author

ghost commented Sep 21, 2021

TXID: ce2ffa35e66dd4992f631dfafbca523f498259d065b02515aeda4708ef5a0dd6

@chimp1984
Copy link

I looked into bisq-network/bisq#5563 and in my opinion the asked amount is too high also taking into account the review effort. It is basically a copy of the TxIdTextField with removing some parts and renaming fields.

I have not looked in details into bisq-network/bisq#5569 but 600 seems also very high to me.

@ghost
Copy link
Author

ghost commented Sep 29, 2021

@chimp1984 It's my first compensation request and I wasn't fully aware how to charge. I mainly took into account time I've spent on these pull requests. As I'm new here I needed to spend more time that usually to become familiar with codebase etc. Companies usually paid for onboarding time. I think final compensation I'll get will be lower, because of fees and btc coloring.

@chimp1984
Copy link

It's my first compensation request and I wasn't fully aware how to charge.

Yes, I understand, the DAO structure is a new for all of us....

Companies usually paid for onboarding time.

Yes I know, but in companies there is a hire process first and then the company invests in an employee based on that. The DAO works differently. Anyone can partizipate but we do not pay for onboarding (we did in the past and it resulted in negative experience for the DAO). The DAO pays for the delivered value to Bisq, similar like delivered freelance work. How long it takes is not relevant, the result is what counts.

I think final compensation I'll get will be lower, because of fees and btc coloring.

The BSQ fee is very low (2 BSQ) for the compensation proposal and the required BTC input is also rather low. The bigger impact is the volatility risk BSQ-BTC and BTC-USD. That can play in both directions, so either good or bad for the contributor, but usually should not be too much of an impact if BTC volatility is not super high.

@ghost
Copy link
Author

ghost commented Sep 30, 2021

@chimp1984 I see you received 3000 USD for this pull request which was in fact small refactoring...

@ripcurlx
Copy link
Contributor

@chimp1984 I see you received 3000 USD for this pull request which was in fact small refactoring...

Did you look into the PR in detail and what it is actually about?

@ghost
Copy link
Author

ghost commented Sep 30, 2021

@ripcurlx Very roughtly, but you guys motivated me to review it more precisely :)

@ghost
Copy link

ghost commented Sep 30, 2021

Issuance by Team:

team amount BSQ amount USD
dev 625.00 950.00

Total Issuance: 625.00 BSQ (equivalent to: 950.00 USD)

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Sep 30, 2021
@MwithM
Copy link
Contributor

MwithM commented Sep 30, 2021

Closed as accepted.

@MwithM MwithM closed this as completed Sep 30, 2021
@ghost ghost mentioned this issue Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants