-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expressFormat option seems to ignore colorize: false #86
Comments
I think your understanding is correct, so I think this is a bug. I'll try to have a look at it in the next couple of days. Thanks! |
👍 |
Sorry, life is busy. So this is wholly related to the condition right here:
I don't think that If either of you want to remove the |
has this been resolved? what's the workaround? I don't even see |
Sorry, this is on me. It is not resolved. Resolving it will require a breaking change (roughly along these lines: c464572) and a major version bump (which will probably also include another breaking change or two). I think the only workaround at the moment is to not use The |
Fixed and released in 2.0.0. |
I'm using a winston logger in my app:
In addition, I use a request logger with express-winston configured to use the same winston instance:
Despite
colorize: false
being set the requestLogger seems to produce ANSI escape sequences for colors:My understanding of the option (based on the comment in the code sample:
"Use the default Express/morgan request formatting, with the same colors. Enabling this will override any msg and colorStatus if true. Will only output colors on transports with colorize set to true") was that it should not output these escape sequences for a transport with the given config. Is this correct?
The text was updated successfully, but these errors were encountered: