Unknown Timezone Warning

[Sh4d0wHunt3rX]

I got this on 2.0.0.4569rc0

[TheTechromancer]

This is most likely bubbling up from the whois library inside baddns:

@liquidsec I thought we fixed this? We need to make sure all output is silenced from that library.

[liquidsec]

Silencing all output caused a MAJOR bug last time we tried.

The author of whois (https://github.com/richardpenman/whois/) was inactive for a long period, but has recently been very active, fixing a lot of things and pushing updates about once a month.

if you can show me how to reproduce it, i can test against newer versions of whois, but right now I have no idea how to reproduce this.

[TheTechromancer]

Considering this library has been a repeat offender I think we need to think about separating it into its own process; i.e. giving it its own dedicated stdout, so we can safely silence it without the risk of introducing another bug in core BBOT.

This isn't specific to whois, as there are other modules like unstructured that have lots of jank complexity that tend to cause problems like strange errors and corruptions in the core process.

This is a direction we should try and lean towards as we continue to add more and more BBOT modules -- only import trusted, lean, and well-tested libraries into the main process, while keeping others safely inside their own. This improves stability but also performance since it gives both the module and BBOT more breathing room to do their thing.

[liquidsec]

I'm totally down for all that, let me know if/how I can assist. That being said, i'd still like to "de-jank" things as much as I can. I will probably go ahead and upgrade whois in baddns soon, and if it seems ok we can flip the version in dev here and see if we notice anything.

[TheTechromancer]

Okay, yeah this is a long-term thing but I think what would be ideal is if the baddns CLI supported checking multiple hosts at a time, and a JSON output format. That way we could batch the DNS_NAMEs similar to how we do with httpx.