From 6621e98df488e6d3e0eb0017caaae180c9f8136a Mon Sep 17 00:00:00 2001 From: whyrusleeping Date: Wed, 3 Apr 2024 11:17:57 -0700 Subject: [PATCH 1/2] fix handle resolution in some cli commands --- cmd/gosky/admin.go | 12 ++++++------ cmd/gosky/handle.go | 11 ++++++----- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/cmd/gosky/admin.go b/cmd/gosky/admin.go index b1914c4fb..4df0925e1 100644 --- a/cmd/gosky/admin.go +++ b/cmd/gosky/admin.go @@ -623,25 +623,25 @@ var takeDownAccountCmd = &cli.Command{ for _, did := range cctx.Args().Slice() { if !strings.HasPrefix(did, "did:") { - phr := &api.ProdHandleResolver{} - resp, err := phr.ResolveHandleToDid(ctx, did) + dir := identity.DefaultDirectory() + resp, err := dir.LookupHandle(ctx, syntax.Handle(did)) if err != nil { return err } - did = resp + did = resp.DID.String() } reason := cctx.String("reason") adminUser := cctx.String("admin-user") if !strings.HasPrefix(adminUser, "did:") { - phr := &api.ProdHandleResolver{} - resp, err := phr.ResolveHandleToDid(ctx, adminUser) + dir := identity.DefaultDirectory() + resp, err := dir.LookupHandle(ctx, syntax.Handle(adminUser)) if err != nil { return err } - adminUser = resp + adminUser = resp.DID.String() } resp, err := toolsozone.ModerationEmitEvent(ctx, xrpcc, &toolsozone.ModerationEmitEvent_Input{ diff --git a/cmd/gosky/handle.go b/cmd/gosky/handle.go index c0c7e2e6c..119bc1798 100644 --- a/cmd/gosky/handle.go +++ b/cmd/gosky/handle.go @@ -4,8 +4,9 @@ import ( "context" "fmt" - api "github.com/bluesky-social/indigo/api" comatproto "github.com/bluesky-social/indigo/api/atproto" + "github.com/bluesky-social/indigo/atproto/identity" + "github.com/bluesky-social/indigo/atproto/syntax" "github.com/bluesky-social/indigo/util/cliutil" cli "github.com/urfave/cli/v2" @@ -32,13 +33,13 @@ var resolveHandleCmd = &cli.Command{ } handle := args[0] - phr := &api.ProdHandleResolver{} - out, err := phr.ResolveHandleToDid(ctx, handle) + dir := identity.DefaultDirectory() + resp, err := dir.LookupHandle(ctx, syntax.Handle(handle)) if err != nil { - return err + return fmt.Errorf("resolving %q: %w", handle, err) } - fmt.Println(out) + fmt.Println(resp.DID) return nil }, From 2f49d1e45c9542d637e4e97b4b818093fa5fca00 Mon Sep 17 00:00:00 2001 From: whyrusleeping Date: Wed, 3 Apr 2024 11:26:14 -0700 Subject: [PATCH 2/2] more handle resolving fixes, also switch to mod.bsky.app where necessary --- cmd/gosky/admin.go | 6 +++++- cmd/gosky/handle.go | 13 +++++++++---- cmd/gosky/main.go | 2 +- 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/cmd/gosky/admin.go b/cmd/gosky/admin.go index 4df0925e1..769577e5e 100644 --- a/cmd/gosky/admin.go +++ b/cmd/gosky/admin.go @@ -29,6 +29,10 @@ var adminCmd = &cli.Command{ EnvVars: []string{"ATP_AUTH_ADMIN_PASSWORD"}, Required: true, }, + &cli.StringFlag{ + Name: "admin-endpoint", + Value: "https://mod.bsky.app", + }, }, Subcommands: []*cli.Command{ buildInviteTreeCmd, @@ -78,7 +82,7 @@ var checkUserCmd = &cli.Command{ adminKey := cctx.String("admin-password") xrpcc.AdminToken = &adminKey - xrpcc.Host = id.PDSEndpoint() + xrpcc.Host = cctx.String("admin-endpoint") rep, err := toolsozone.ModerationGetRepo(ctx, xrpcc, did) if err != nil { diff --git a/cmd/gosky/handle.go b/cmd/gosky/handle.go index 119bc1798..ae32ab801 100644 --- a/cmd/gosky/handle.go +++ b/cmd/gosky/handle.go @@ -31,15 +31,20 @@ var resolveHandleCmd = &cli.Command{ if err != nil { return err } - handle := args[0] + + h, err := syntax.ParseHandle(args[0]) + if err != nil { + return fmt.Errorf("resolving %q: %w", args[0], err) + } dir := identity.DefaultDirectory() - resp, err := dir.LookupHandle(ctx, syntax.Handle(handle)) + + res, err := dir.LookupHandle(ctx, h) if err != nil { - return fmt.Errorf("resolving %q: %w", handle, err) + return err } - fmt.Println(resp.DID) + fmt.Println(res.DID) return nil }, diff --git a/cmd/gosky/main.go b/cmd/gosky/main.go index 028cd0196..6a3cfabd4 100644 --- a/cmd/gosky/main.go +++ b/cmd/gosky/main.go @@ -765,7 +765,7 @@ var listLabelsCmd = &cli.Command{ since := time.Now().Add(-1 * delta).UnixMilli() xrpcc := &xrpc.Client{ - Host: "https://api.bsky.app", + Host: "https://mod.bsky.app", } for {