Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silly code inside CustomSegmentedControl class #23

Open
gerchicov opened this issue Jul 2, 2013 · 0 comments
Open

Silly code inside CustomSegmentedControl class #23

gerchicov opened this issue Jul 2, 2013 · 0 comments

Comments

@gerchicov
Copy link

Your CustomSegmentedControl and CustomSegmentedControlsViewController are closely connected. So it takes a lot of time to recreate the first one as a separate control.
Why did you transfer a half of parameters from the first class to the second one? Such as offset, CapLocation.
Some extra parameters: TAG_VALUE
Why do you declare buttons as array of dictionaries of arrays and even make it static?
And finally WHY do you customise the buttons of your custom segmented control completely outside it? Ponder "custom segmenter control" meaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant