Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomTabBar: Various UITabBarController behaviors are missing #5

Open
jdandrea opened this issue Jul 21, 2011 · 1 comment
Open

CustomTabBar: Various UITabBarController behaviors are missing #5

jdandrea opened this issue Jul 21, 2011 · 1 comment

Comments

@jdandrea
Copy link

  1. View Controllers aren't sent viewWill/DidAppear/Disappear during touchDownAtItemAtIndex:.
  2. Tapping an already selected tab bar item does not pop the selected view controller's navigation controller (if any) to the root VC.
  3. Using hidesBottomBarWhenPushed has no effect.

Item 1 is easy enough. Per Apple docs:

Warning: If the view belonging to a view controller is added to a view hierarchy directly, the view controller will not receive (viewWill/DidAppear/Disappear). If you insert or add a view to the view hierarchy, and it has a view controller, you should send the associated view controller this message directly. Failing to send the view controller this message will prevent any associated animation from being displayed.

Alas, I'm running into some interesting dead-ends with Items 2 and 3. (Might just be pilot error.) Rather than hunting these down one by one as they crop up, I wonder if its desirable to subclass UITabBarController itself, but just draw it in the most excellent way you've done here? Pros/cons? (Con: Apple does not advise subclassing it!)

@mureev
Copy link

mureev commented Aug 19, 2011

1 and 2 fixed here #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants