Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecvt_null.hpp unconditional symbols leakage #244

Open
claimred opened this issue Dec 30, 2021 · 1 comment
Open

codecvt_null.hpp unconditional symbols leakage #244

claimred opened this issue Dec 30, 2021 · 1 comment

Comments

@claimred
Copy link

claimred commented Dec 30, 2021

Why does codecvt_null.hpp file declares symbols with BOOST_SYMBOL_EXPORT instead of BOOST_ARCHIVE_DECL?

https://github.com/boostorg/serialization/blob/develop/include/boost/archive/codecvt_null.hpp#L69

https://github.com/boostorg/serialization/blob/develop/include/boost/archive/detail/decl.hpp#L26

It leads to symbols leakage in DLLs statically linking boost.archive.

@robertramey
Copy link
Member

It's probably a mistake as I had lots of difficulty with symbol export macros. Have you made this change and run the tests to verify that making this change doesn't break anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants