create_tags backtraces when multiples tags are passed

[iMilnb]

When passing multiple tags to the create_tags method, I get the following backtrace:

  File "boto/ec2.py", line 160, in create
    'Customer': instance['customer']
  File "/usr/home/imil/aws/awscli/lib/python2.7/site-packages/boto3/resources/fa
ctory.py", line 340, in do_action
    response = action(self, *args, **kwargs)
  File "/usr/home/imil/aws/awscli/lib/python2.7/site-packages/boto3/resources/ac
tion.py", line 81, in __call__
    return self._response_handler(parent, params, response)
  File "/usr/home/imil/aws/awscli/lib/python2.7/site-packages/boto3/resources/re
sponse.py", line 240, in __call__
    parent, identifiers, response_item))
  File "/usr/home/imil/aws/awscli/lib/python2.7/site-packages/boto3/resources/re
sponse.py", line 284, in handle_response_item
    value = value.pop(0)
IndexError: pop from empty list

When creating a loop where I create the tags one after the other, everything is going smoothly.

For the record, the taglist has this form:

[{
    'Key': 'Name',
    'Value': 'myinstance'
},{
    'Key': 'Customer',
    'Value': 'mycustomer'
}]

I use boto3 0.0.21

[jamesls]

Can you share a code snippet that shows the issue? Here's what I tried, which is working for me:

In [1]: import boto3

In [2]: c = boto3.client('ec2', 'us-west-2')

In [3]: c.create_tags(Resources=['i-id'], Tags=[{'Key': 'foo', 'Value': 'bar'}, {'Key': 'foo2', 'Value': 'bar2'}])
Out[3]:
{'ResponseMetadata': {'HTTPStatusCode': 200,
  'RequestId': 'requestid'}}

[iMilnb]

Of course:

    def mktags(self, taglst):
        '''Makes a Filter-friendly tag list

        :param dict taglst: A dict of key / value pairs

        :return: Filter-friendly tag list
        :rtype: dict
        '''
        tags = []
        for t in taglst:
            tags.append({'Key': t, 'Value': taglst[t]})
        return tags

then the main call:

                        tags = {
                            'Name': '{0}_{1}'.format(
                                dname, instance['name']
                            ),
                            'Customer': instance['customer']
                        }
                        ec2.resource.create_tags(
                            Resources = [dev['Ebs']['VolumeId']],
                            Tags = mktags(tags)
                        )

This code works with a single {'Key': 'foo', 'Value': 'bar'} item

Update

When using ec2.client.create_tags, I have the intended behavior, this bug concerns the resource way of doing things.

[kyleknap]

I can confirm the issue. It looks like we are not handling the case where multiple resources can be returned by an action.

[jamesls]

Fixed via #160