[CLOSED] Fix for dropping projects when cancelling switch (#1780)

[core-ai-bot]

Issue by jbalsas
Thursday Nov 01, 2012 at 12:28 GMT
Originally opened as adobe/brackets#2013

---

Possible fix for adobe/brackets#1780

As@pthiess pointed out, checking to see if the folder exists to prevent it from being dropped.

---

jbalsas included the following code: https://github.com/adobe/brackets/pull/2013/commits

[core-ai-bot]

Comment by redmunds
Thursday Nov 01, 2012 at 16:44 GMT

---

This looks good. Just a couple minor changes.

[core-ai-bot]

Comment by jbalsas
Friday Nov 02, 2012 at 00:20 GMT

---

@redmunds It should be good to go now.

As a side note, passing fault codes in the reject calls could be helpful in cases like this. In this issue, there are at least 4 ways openProject can fail, and only one should require dropping the project from the list, but we need to check every time anyway.

A quick search reveals that less than half the reject calls are passing some error code, but I guess it can become a mess for some cases that end up chaining different promises though...

[core-ai-bot]

Comment by redmunds
Friday Nov 02, 2012 at 01:59 GMT

---

This is not common case, so I think this is OK. Looks good. Merging.