Skip to content
This repository has been archived by the owner on Jun 30, 2020. It is now read-only.

Allow VV to create wildcard subdomain sites #94

Closed
bradp opened this issue Mar 25, 2015 · 3 comments
Closed

Allow VV to create wildcard subdomain sites #94

bradp opened this issue Mar 25, 2015 · 3 comments
Assignees

Comments

@bradp
Copy link
Owner

bradp commented Mar 25, 2015

No description provided.

@bradp bradp self-assigned this May 20, 2015
@lvgunst
Copy link

lvgunst commented Jul 1, 2015

$multisite_domains on https://github.com/bradp/vv/blob/master/vv#L807 is undefined. Shouldn't this be something like *.$domain?

I don't think hosts files support wildcard domains. So for now you have to manually add subdomains to the vvv-hosts file of your multisite.

@bradp
Copy link
Owner Author

bradp commented Jul 1, 2015

The original plan was to prompt for subdomain sites somehow and populate that list.

You are correct, there isn't a great way to do wildcard domains, and right now the process does need to be manually adding them to vvv-hosts and to ngnix config.

I think a way to add a new subdomain without manual editing is what vv really needs.

@michaelryanmcneill
Copy link
Contributor

In my opinion, I think it would be best to have the nginx config account for the wildcard (*.$domain) and have the user add the domain to the hosts file manually. That is the way VVV does it by default (per: Varying-Vagrant-Vagrants/VVV#284 (comment)), and I believe following their lead is the best way to offer as close to a resolution as possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants