Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages of killed clients don't get interrupted #942

Open
sthibaul opened this issue Jul 10, 2024 · 1 comment
Open

messages of killed clients don't get interrupted #942

sthibaul opened this issue Jul 10, 2024 · 1 comment

Comments

@sthibaul
Copy link
Collaborator

Steps to reproduce

  • make orca produce long message
  • kill it -KILL

Obtained behavior

  • the message continues

Expected behavior

  • we'd want the message to stop, so that e.g. orca -r restarts speech immediately

Behavior information

  • we however don't want the message of spd-say without -w to be stopped
@sthibaul
Copy link
Collaborator Author

We could add a QUIT command that clients use when they are leaving (i.e. spd_close), so that speech dispatcher knows they are exiting properly, and did take care of canceling the message if they wanted to.

If speech dispatcher notices a client sockets gets closed without a QUIT command, it should then cancel its messages, since it probably means the client just crashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant